From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: lekktu@gmail.com, 14970@debbugs.gnu.org
Subject: bug#14970: crash deleting frames
Date: Mon, 29 Jul 2013 18:29:20 +0300 [thread overview]
Message-ID: <83vc3txu3z.fsf@gnu.org> (raw)
In-Reply-To: <51F61FD2.9060600@gmx.at>
> Date: Mon, 29 Jul 2013 09:54:58 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: lekktu@gmail.com, 14970@debbugs.gnu.org
>
> > ... (you cannot just
> > use FRAME_LIVE_P here, because it will crash in the same way).
>
> How does it crash?
The original crash was a SIGSEGV because f was a null pointer, and
FRAME_SELECTED_WINDOW dereferenced it. But FRAME_LIVE_P also
dereferences its argument, so it would have crashed with the same
SIGSEGV.
I guess you are thinking about a frame pointer computed from a Lisp
frame object, in which case the pointer can never be null. But this
is not that case: here we get the frame pointer from a call to
x_window_to_frame, which returns a null pointer to signal that it
failed to find an Emacs frame that corresponds to a Windows window.
next prev parent reply other threads:[~2013-07-29 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 0:22 bug#14970: crash deleting frames Juanma Barranquero
2013-07-28 1:08 ` Juanma Barranquero
2013-07-28 8:39 ` martin rudalics
2013-07-28 15:28 ` Eli Zaretskii
2013-07-29 7:54 ` martin rudalics
2013-07-29 15:29 ` Eli Zaretskii [this message]
2013-07-29 17:03 ` martin rudalics
2013-07-28 15:25 ` Eli Zaretskii
2013-07-28 17:04 ` Juanma Barranquero
2013-07-28 17:28 ` Eli Zaretskii
2013-07-28 17:34 ` Juanma Barranquero
2013-07-28 17:37 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vc3txu3z.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=14970@debbugs.gnu.org \
--cc=lekktu@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).