From: Eli Zaretskii <eliz@gnu.org>
To: "Alex Bennée" <kernel-hacker@bennee.com>
Cc: 16599@debbugs.gnu.org, schwab@linux-m68k.org
Subject: bug#16599: src/temacs --daemon fails
Date: Mon, 17 Feb 2014 17:51:46 +0200 [thread overview]
Message-ID: <83vbwd91pp.fsf@gnu.org> (raw)
In-Reply-To: <877g8unq4s.fsf@bennee.com>
> From: Alex Bennée <kernel-hacker@bennee.com>
> Cc: Alex Bennée <kernel-hacker@bennee.com>, Eli Zaretskii
> <eliz@gnu.org>, 16599@debbugs.gnu.org, emacs-devel@gnu.org
> Date: Mon, 17 Feb 2014 07:40:35 +0000
>
> Why did the syms_of_emacs() function feel the need to initialise daemon_pipe?
Because in a dumped Emacs, daemon_pipe might hold a stale value from
before the dumping.
Does the patch below solve this problem?
=== modified file 'src/emacs.c'
--- src/emacs.c 2014-01-20 19:44:56 +0000
+++ src/emacs.c 2014-02-17 15:48:44 +0000
@@ -2550,5 +2550,6 @@ libraries; only those already known by E
#endif
/* Make sure IS_DAEMON starts up as false. */
- daemon_pipe[1] = 0;
+ if (initialized)
+ daemon_pipe[1] = 0;
}
next prev parent reply other threads:[~2014-02-17 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87bnyt5zmi.fsf@linaro.org>
[not found] ` <83k3dh7837.fsf@gnu.org>
2014-02-16 21:34 ` bug#16599: src/temacs --daemon fails Alex Bennée
2014-02-16 21:57 ` Andreas Schwab
[not found] ` <871tz2iuuu.fsf@igel.home>
2014-02-17 7:40 ` Alex Bennée
[not found] ` <877g8unq4s.fsf@bennee.com>
2014-02-17 15:51 ` Eli Zaretskii [this message]
2014-02-17 16:03 ` Andreas Schwab
2014-02-17 16:15 ` Eli Zaretskii
2014-02-17 16:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vbwd91pp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=16599@debbugs.gnu.org \
--cc=kernel-hacker@bennee.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).