From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20154: 25.0.50; json-encode-string is too slow for large strings Date: Sun, 22 Mar 2015 18:50:05 +0200 Message-ID: <83vbhtrn7m.fsf@gnu.org> References: <86twxf68zk.fsf@yandex.ru> <83384zwxdx.fsf@gnu.org> <550C3218.4000903@yandex.ru> <831tkjww0y.fsf@gnu.org> <550C3AB9.7020403@yandex.ru> <83wq2bveq6.fsf@gnu.org> <550C491A.6000909@yandex.ru> <83siczvcss.fsf@gnu.org> <550C504A.10708@yandex.ru> <83r3sjva0q.fsf@gnu.org> <550C6A06.6040203@yandex.ru> <83fv8zv0b1.fsf@gnu.org> <550C9E7B.4060907@yandex.ru> <837fuavkn9.fsf@gnu.org> <550DDE25.1090000@yandex.ru> <550ED713.2010201@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1427043090 4426 80.91.229.3 (22 Mar 2015 16:51:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Mar 2015 16:51:30 +0000 (UTC) Cc: 20154@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 22 17:51:18 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZj5n-0001su-CE for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Mar 2015 17:51:15 +0100 Original-Received: from localhost ([::1]:51710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZj5l-0002vh-CC for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Mar 2015 12:51:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZj5i-0002u3-1A for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 12:51:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZj5a-00046E-Sf for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 12:51:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZj5a-000468-Oz for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 12:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YZj5a-00047i-B9 for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2015 12:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Mar 2015 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20154-submit@debbugs.gnu.org id=B20154.142704303215808 (code B ref 20154); Sun, 22 Mar 2015 16:51:02 +0000 Original-Received: (at 20154) by debbugs.gnu.org; 22 Mar 2015 16:50:32 +0000 Original-Received: from localhost ([127.0.0.1]:60846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZj55-00046t-4D for submit@debbugs.gnu.org; Sun, 22 Mar 2015 12:50:31 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:48627) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZj52-00046c-Ny for 20154@debbugs.gnu.org; Sun, 22 Mar 2015 12:50:29 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NLM00400GPP6G00@mtaout24.012.net.il> for 20154@debbugs.gnu.org; Sun, 22 Mar 2015 18:42:40 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NLM00OR4H34SI50@mtaout24.012.net.il>; Sun, 22 Mar 2015 18:42:40 +0200 (IST) In-reply-to: <550ED713.2010201@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100789 Archived-At: > Date: Sun, 22 Mar 2015 16:52:03 +0200 > From: Dmitry Gutov > CC: 20154@debbugs.gnu.org > > (defun json-encode-string-3 (string) > "Return a JSON representation of STRING." > ;; Reimplement the meat of `replace-regexp-in-string', for > ;; performance (bug#20154). > (let ((l (length string)) > (start 0) > (res (list "\""))) > ;; Skip over ASCIIish printable characters. > (while (string-match "[\"\\/\b\f\n\r\t]\\|[^ -~]" string start) > (let* ((mb (match-beginning 0)) > (c (aref string mb)) > (special (rassoc c json-special-chars))) Did you try a 'cond' with specific characters instead of calling rassoc every time? The list in json-special-chars is not long, is it?