unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Rupert Swarbrick <ruperts@broadcom.com>
Cc: 21168-done@debbugs.gnu.org
Subject: bug#21168: 25.0.50; ffap-string-at-point-region gets raw cons value, breaking	ffap-string-at-point
Date: Sat, 01 Aug 2015 12:35:04 +0300	[thread overview]
Message-ID: <83vbczuzav.fsf@gnu.org> (raw)
In-Reply-To: <889fv44nurs.fsf@broadcom.com>

> From: Rupert Swarbrick <ruperts@broadcom.com>
> Date: Fri, 31 Jul 2015 17:42:31 +0100
> 
> My Emacs session has got into a situation where the
> ffap-string-at-point-region is the raw cons
> 
>   (14812 . 2284)
> 
> As a result, the line at the bottom of ffap-string-at-point fails
> when it tries to run
> 
>   (setcar (cdr ffap-string-at-point-region) end)
> 
> 
> I'm running Emacs compiled from commit 123c82e, plus an unrelated commit
> to fix the scheme lexer for semantic (hence the weird looking repository
> version below).
> 
> 
> I think the problem is probably caused by commit e48a116780d (from last
> Wednesday), which changes line 1137 of ffap.el to:
> 
>             (setcdr ffap-string-at-point-region (point))
> 
> because the rest of ffap.el expects the variable to be a list with two
> elements rather than a cons pair.
> 
> 
> I've changed the line to 
> 
>             (setcar (cdr ffap-string-at-point-region) (point))
> 
> and stuff seems to work fine.

Thanks, I fixed that in a slightly different way.





      reply	other threads:[~2015-08-01  9:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 16:42 bug#21168: 25.0.50; ffap-string-at-point-region gets raw cons value, breaking ffap-string-at-point Rupert Swarbrick
2015-08-01  9:35 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83vbczuzav.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=21168-done@debbugs.gnu.org \
    --cc=ruperts@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).