From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21333: 25.0.50; window-size-change-functions not called after mini-window resize Date: Mon, 24 Aug 2015 21:30:30 +0300 Message-ID: <83vbc4fsjd.fsf@gnu.org> References: <83k2skhhz1.fsf@gnu.org> <55DB5D3E.1000706@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1440441094 21238 80.91.229.3 (24 Aug 2015 18:31:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Aug 2015 18:31:34 +0000 (UTC) Cc: pipcet@gmail.com, 21333@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 24 20:31:23 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZTwWY-00069f-Bj for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Aug 2015 20:31:14 +0200 Original-Received: from localhost ([::1]:56010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTwWX-0003Oa-7M for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Aug 2015 14:31:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTwWS-0003Na-IT for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2015 14:31:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTwWM-0003ee-S9 for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2015 14:31:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTwWM-0003eP-PW for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2015 14:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZTwWM-0006k7-J7 for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2015 14:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2015 18:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21333-submit@debbugs.gnu.org id=B21333.144044104625890 (code B ref 21333); Mon, 24 Aug 2015 18:31:02 +0000 Original-Received: (at 21333) by debbugs.gnu.org; 24 Aug 2015 18:30:46 +0000 Original-Received: from localhost ([127.0.0.1]:37216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTwW6-0006jV-63 for submit@debbugs.gnu.org; Mon, 24 Aug 2015 14:30:46 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:42244) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTwW3-0006jL-Ss for 21333@debbugs.gnu.org; Mon, 24 Aug 2015 14:30:44 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NTL00C00N9ZV500@a-mtaout23.012.net.il> for 21333@debbugs.gnu.org; Mon, 24 Aug 2015 21:30:42 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NTL00CTXNF6UY00@a-mtaout23.012.net.il>; Mon, 24 Aug 2015 21:30:42 +0300 (IDT) In-reply-to: <55DB5D3E.1000706@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105786 Archived-At: > Date: Mon, 24 Aug 2015 20:06:54 +0200 > From: martin rudalics > CC: 21333@debbugs.gnu.org > > > That said, I wonder whether changing the code now to call these > > functions due to automatic resizing would make sense. What would be > > the real-life use cases for using that? > > Naively spoken it's obvious that when you shrink the minibuffer you show > more lines in the window above and ‘linum-mode’ has to add numbers for > those lines. And when you enlarge the minibuffer, ‘follow-mode’ will > lose some lines at the bottom of the left window and has to show them at > the top of the right window. In well-behaved modes this happens automatically, as part of redisplay. > Maybe they use the ‘post-command-hook’ function instead. Of course, they do! The flag of bad design. > > If anything, IMO we should _reduce_ the number of unrelated events > > that trigger a call to these functions. For example, currently any > > command that reads from the minibuffer will trigger it, because when > > read-from-minibuffer exits, it restores the window configuration by > > calling set-window-configuration, which is documented to trigger these > > functions. That just doesn't make any sense to me, since most reads > > from the minibuffer don't resize any windows! > > This is, in fact, an abuse of ‘set-window-configuration’. But how fix > it? We'd need a hook, say ‘window-size-change-functions’, that tracks, > among other things, whether a window was resized due to a change of the > minibuffer height and, if that happens, set a flag to indicate that the > window configuration must be restored. I'd say, don't set the "size changed" flag unless the size really changed.