From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21707: include-file cleanup for src directory Date: Mon, 19 Oct 2015 10:23:02 +0300 Message-ID: <83vba3gw4p.fsf@gnu.org> References: <56249650.5050804@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1445239507 2387 80.91.229.3 (19 Oct 2015 07:25:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Oct 2015 07:25:07 +0000 (UTC) Cc: 21707@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 19 09:24:56 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zo4oS-0008RS-6Q for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Oct 2015 09:24:56 +0200 Original-Received: from localhost ([::1]:36949 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo4oM-00053O-8m for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 Oct 2015 03:24:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo4nf-0004Rp-Td for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 03:24:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zo4nb-0002Ys-1Z for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 03:24:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zo4na-0002Yi-Ct for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 03:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zo4na-0005jS-2c for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2015 03:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Oct 2015 07:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21707 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21707-submit@debbugs.gnu.org id=B21707.144523940921985 (code B ref 21707); Mon, 19 Oct 2015 07:24:02 +0000 Original-Received: (at 21707) by debbugs.gnu.org; 19 Oct 2015 07:23:29 +0000 Original-Received: from localhost ([127.0.0.1]:55662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zo4n3-0005iX-DL for submit@debbugs.gnu.org; Mon, 19 Oct 2015 03:23:29 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:46651) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zo4n1-0005iO-H6 for 21707@debbugs.gnu.org; Mon, 19 Oct 2015 03:23:28 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NWG00800HJCOU00@mtaout29.012.net.il> for 21707@debbugs.gnu.org; Mon, 19 Oct 2015 10:22:24 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWG00NAJHTAWJB0@mtaout29.012.net.il>; Mon, 19 Oct 2015 10:22:24 +0300 (IDT) In-reply-to: <56249650.5050804@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107737 Archived-At: > From: Paul Eggert > Date: Mon, 19 Oct 2015 00:05:52 -0700 > > Attached is a patch to remove unnecessary #include directives from the src > directory, and add a few #include directives that should be there. I'm not > installing this now, to give Eli a heads-up in case this affects the MS-Windows > port. I had compilation warnings and errors due to redisplaying_p and cancel_hourglass not being declared in eval.c and lread.c. These two files need to include dispextern.h to avoid that problem. (This isn't Windows specific, so I wonder how it compiled for you.) Otherwise, LGTM, thanks. Would someone with MinGW64 installed please try this patch and see that it works there as well?