From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21816: elisp-mode-tests fails on a case-preserving filesystem Date: Mon, 02 Nov 2015 19:57:01 +0200 Message-ID: <83vb9kwahe.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1446487108 26061 80.91.229.3 (2 Nov 2015 17:58:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Nov 2015 17:58:28 +0000 (UTC) Cc: 21816@debbugs.gnu.org, stephen_leake@stephe-leake.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 02 18:58:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZtJMw-0000yw-Ei for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Nov 2015 18:58:10 +0100 Original-Received: from localhost ([::1]:43639 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtJMv-0001xA-SW for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Nov 2015 12:58:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtJMr-0001wj-DO for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 12:58:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtJMo-0006Bd-6e for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 12:58:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtJMo-0006BZ-3b for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 12:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZtJMn-0003Ni-OI for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 12:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Nov 2015 17:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21816-submit@debbugs.gnu.org id=B21816.144648704312947 (code B ref 21816); Mon, 02 Nov 2015 17:58:01 +0000 Original-Received: (at 21816) by debbugs.gnu.org; 2 Nov 2015 17:57:23 +0000 Original-Received: from localhost ([127.0.0.1]:49935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtJMA-0003Mk-Sa for submit@debbugs.gnu.org; Mon, 02 Nov 2015 12:57:23 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:54767) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtJLq-0003MK-Pn for 21816@debbugs.gnu.org; Mon, 02 Nov 2015 12:57:22 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NX700B008BEAE00@a-mtaout23.012.net.il> for 21816@debbugs.gnu.org; Mon, 02 Nov 2015 19:56:49 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NX700B168IO45A0@a-mtaout23.012.net.il>; Mon, 02 Nov 2015 19:56:49 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108311 Archived-At: > From: Juanma Barranquero > Date: Mon, 2 Nov 2015 17:41:58 +0100 > Cc: stephen_leake@stephe-leake.org > > Test xref-elisp-test-find-defs-feature-el fails on my Windows system because of > a case-sensitive filename comparison. > > Basically > > ELISP> (aref (aref (car (elisp--xref-find-definitions 'xref)) 2) 3) > "c:/devel/emacs/repo/trunk/lisp/progmodes/xref.el" > > ELISP> (aref (xref-make-elisp-location > 'xref 'feature > (expand-file-name "../../lisp/progmodes/xref.el" > emacs-test-dir)) > 3) > "c:/Devel/emacs/repo/trunk/lisp/progmodes/xref.el" > > and the test fails at the d/D in c:/Devel vs. c:/devel (as seen in the log > below). > > The value returned by `expand-file-name' is the real name as stored in the > filesystem (the directory is called "Devel"). The value from > `elisp--xref-find-definitions' ultimately comes from `locate-file', and > reflects what's stored in `load-path' (which can be set by the user, so we > cannot force it to have "correct" casing). > > ELISP> (locate-file "xref" load-path '(".el")) > "c:/devel/emacs/repo/trunk/lisp/progmodes/xref.el" > ELISP> (locate-file "xref" '("c:/Devel/emacs/repo/trunk/lisp/progmodes") ' > (".el")) > "c:/Devel/emacs/repo/trunk/lisp/progmodes/xref.el" > > The test code in elisp-mode-tests.el uses `equal' to compare the xref > structures. I can think a couple of ways to fix the test, but they are all > quite ugly.... The comparison should use file-equal-p.