From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 22692@debbugs.gnu.org, m.kupfer@acm.org
Subject: bug#22692: docstring for xref-find-definitions
Date: Fri, 19 Feb 2016 17:34:06 +0200 [thread overview]
Message-ID: <83vb5kr9xt.fsf@gnu.org> (raw)
In-Reply-To: <56C7123A.6040408@yandex.ru> (message from Dmitry Gutov on Fri, 19 Feb 2016 15:01:46 +0200)
> Cc: 22692@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 19 Feb 2016 15:01:46 +0200
>
> On 02/18/2016 06:50 PM, Eli Zaretskii wrote:
>
> > Failing that, the only band-aid I can offer is something like
> >
> > Find the definition of the identifier at or near point.
> >
> > If you think it's better, we can make that change now.
>
> Do we really want to codify that behavior? I've switched to use
> find-tag--default because it seemed appropriate for the etags backend,
> but the "near point" aspect looks fairly awkward to me, and I imagine
> third-party backends might choose to omit it.
>
> I'd prefer to use the more precise behavior in find-tag-default-bounds
> as well. And if there's general agreement here, I wouldn't mind taking
> care of that patch.
Making such a change is fine with me, thanks.
> > Did you use M-. in Emacs 24 and before? Because that's exactly what
> > it did in this case, it would say this in the echo area:
> >
> > Find tag (default 1):
> >
> > The reason is that this is what etags.el does when asked to find "the
> > identifier at or near point". Patches to make it smarter are welcome.
> > (The relevant function is find-tag-default-bounds.)
>
> Not necessarily. Every major mode that knows better should define its
> own find-tag-default-function (but none do, so far). See the dispatch
> inside find-tag--default.
If find-tag-default-function is also used by xref-find-references,
then it won't be TRT to reject constants up front. A request to find
all the places where a certain constant is used is a valid use case.
It is indeed unlikely to have such a request for the constant 1, but
think about constants like 3.14159 or 3.0e+8.
next prev parent reply other threads:[~2016-02-19 15:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 1:02 bug#22692: 25.0.91; xref-find-definitions fails to prompt Mike Kupfer
2016-02-16 3:44 ` Eli Zaretskii
2016-02-16 10:10 ` Dmitry Gutov
2016-02-16 16:01 ` Eli Zaretskii
2016-02-16 10:12 ` Dmitry Gutov
2016-02-17 1:55 ` Mike Kupfer
2016-02-19 13:43 ` Dmitry Gutov
2016-02-19 15:10 ` Mike Kupfer
2016-02-19 15:59 ` Eli Zaretskii
2016-02-19 18:08 ` Dmitry Gutov
2016-02-19 18:37 ` Eli Zaretskii
2016-02-19 18:52 ` Dmitry Gutov
2016-02-19 20:24 ` Eli Zaretskii
2016-02-20 1:28 ` Dmitry Gutov
2016-02-20 8:45 ` Eli Zaretskii
2016-02-21 3:36 ` Mike Kupfer
2016-02-21 22:56 ` Dmitry Gutov
2016-02-23 0:43 ` Dmitry Gutov
2016-02-23 2:19 ` Mike Kupfer
2016-02-18 3:45 ` bug#22692: docstring for xref-find-definitions Mike Kupfer
2016-02-18 16:50 ` Eli Zaretskii
2016-02-18 18:48 ` Mike Kupfer
2016-02-19 13:04 ` Dmitry Gutov
2016-02-19 13:01 ` Dmitry Gutov
2016-02-19 15:34 ` Eli Zaretskii [this message]
2016-02-20 1:24 ` Dmitry Gutov
2016-02-20 8:33 ` Eli Zaretskii
2016-02-23 0:04 ` Juri Linkov
2016-02-23 0:35 ` Dmitry Gutov
2016-02-27 10:32 ` Eli Zaretskii
2016-02-27 12:35 ` Dmitry Gutov
2016-02-27 12:43 ` Eli Zaretskii
2016-02-29 2:48 ` Dmitry Gutov
2016-02-23 0:41 ` Drew Adams
2016-02-21 3:42 ` Mike Kupfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vb5kr9xt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=22692@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=m.kupfer@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).