From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23827: 25.1.50; tab-width file-local variable has no effect in etc/HELLO Date: Fri, 24 Jun 2016 16:28:52 +0300 Message-ID: <83vb0y1zsb.fsf@gnu.org> References: <20160624110713.13909.qmail@mail.muc.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1466775598 20365 80.91.229.3 (24 Jun 2016 13:39:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2016 13:39:58 +0000 (UTC) Cc: 23827@debbugs.gnu.org To: Alan Mackenzie , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 24 15:39:47 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGRKj-0008T9-QF for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Jun 2016 15:39:45 +0200 Original-Received: from localhost ([::1]:43585 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGRKi-0005rT-Qy for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Jun 2016 09:39:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGRCM-0004N5-EY for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2016 09:31:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGRCI-0001JF-Dz for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2016 09:31:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGRCI-0001J9-AM for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2016 09:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bGRCI-0002rs-6I for bug-gnu-emacs@gnu.org; Fri, 24 Jun 2016 09:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jun 2016 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23827 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23827-submit@debbugs.gnu.org id=B23827.146677500510906 (code B ref 23827); Fri, 24 Jun 2016 13:31:02 +0000 Original-Received: (at 23827) by debbugs.gnu.org; 24 Jun 2016 13:30:05 +0000 Original-Received: from localhost ([127.0.0.1]:53521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGRBM-0002pp-DJ for submit@debbugs.gnu.org; Fri, 24 Jun 2016 09:30:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGRBK-0002os-Aw for 23827@debbugs.gnu.org; Fri, 24 Jun 2016 09:30:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGRBB-0000lK-Sl for 23827@debbugs.gnu.org; Fri, 24 Jun 2016 09:29:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGRBB-0000lE-PB; Fri, 24 Jun 2016 09:29:53 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4001 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bGRB7-0001F0-QO; Fri, 24 Jun 2016 09:29:52 -0400 In-reply-to: <20160624110713.13909.qmail@mail.muc.de> (message from Alan Mackenzie on 24 Jun 2016 11:07:13 -0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120000 Archived-At: > Date: 24 Jun 2016 11:07:13 -0000 > From: Alan Mackenzie > Cc: Eli Zaretskii > > However, the C function `set-buffer-major-mode', optimises the call to > `fundamental-mode' away, because that call previously didn't do anything. > > (`set-buffer-major-mode' is the last fallback function which choses the > major mode when all other methods have been tried and failed in > `set-auto-mode'.) > > So I propose to remove that special optimisation from > `set-buffer-major-mode', so that `fundamental-mode' actually gets called. > As an alternative, it would be possible to add special handling at the > Lisp level for `fundamental-mode', but I think that would be a worse fix. > > Here's my proposed patch, which works: > > > diff --git a/src/buffer.c b/src/buffer.c > index b4b8304..8756cbb 100644 > --- a/src/buffer.c > +++ b/src/buffer.c > @@ -1984,7 +1984,9 @@ the current buffer's major mode. */) > function = BVAR (current_buffer, major_mode); > } > > - if (NILP (function) || EQ (function, Qfundamental_mode)) > + if (NILP (function)) /* If function is `fundamental-mode', allow it to run > + so that `run-mode-hooks' and thus > + `hack-local-variables' get run. */ > return Qnil; > > count = SPECPDL_INDEX (); > > > What do you think? LGTM, but I'm not an expert on modes. I'd like to hear opinions from others. Stefan? Thanks.