From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24340: insert-file-contents calls before-change-functions too late Date: Sun, 02 Oct 2016 10:19:05 +0300 Message-ID: <83vaxbjk0m.fsf@gnu.org> References: <8360qim5sv.fsf@gnu.org> <83vayhkogv.fsf@gnu.org> <83inuhkmkv.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1475392825 3579 195.159.176.226 (2 Oct 2016 07:20:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Oct 2016 07:20:25 +0000 (UTC) Cc: 24340@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 02 09:20:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqb4K-0008DJ-T0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2016 09:20:17 +0200 Original-Received: from localhost ([::1]:58398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqb4J-0008J0-3e for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2016 03:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqb4A-0008G1-1K for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 03:20:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqb45-00025t-Ti for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 03:20:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqb45-00025n-QF for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 03:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqb45-0003f3-KQ for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 03:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2016 07:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24340 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24340-submit@debbugs.gnu.org id=B24340.147539274613999 (code B ref 24340); Sun, 02 Oct 2016 07:20:01 +0000 Original-Received: (at 24340) by debbugs.gnu.org; 2 Oct 2016 07:19:06 +0000 Original-Received: from localhost ([127.0.0.1]:41490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqb3C-0003di-LO for submit@debbugs.gnu.org; Sun, 02 Oct 2016 03:19:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqb3B-0003dD-0h for 24340@debbugs.gnu.org; Sun, 02 Oct 2016 03:19:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqb32-0001pL-MZ for 24340@debbugs.gnu.org; Sun, 02 Oct 2016 03:18:59 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqb32-0001ot-J6; Sun, 02 Oct 2016 03:18:56 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2968 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bqb30-0000wE-MA; Sun, 02 Oct 2016 03:18:55 -0400 In-reply-to: (message from Stefan Monnier on Sat, 01 Oct 2016 21:11:34 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123891 Archived-At: > From: Stefan Monnier > Cc: 24340@debbugs.gnu.org > Date: Sat, 01 Oct 2016 21:11:34 -0400 > > > Since I believe master will be used for 25.2, we cannot currently push > > anything that must wait for 26. > > Now that master has been labeled "for 26.1", can we push a patch to it? > I'd happily push my patch to it, but if you prefer a different approach, > feel free to push another patch there instead. I'm okay with your patch only if you promise to be there for fixing any fallout. It scares me quite a lot, especially the fact that it fixes a single use case by making broad changes across the board. Once again, my suggestion is instead to announce a change in the entire buffer, as that is what revert-buffer is all about.