unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 24340@debbugs.gnu.org
Subject: bug#24340: insert-file-contents calls before-change-functions too late
Date: Sun, 02 Oct 2016 10:19:05 +0300	[thread overview]
Message-ID: <83vaxbjk0m.fsf@gnu.org> (raw)
In-Reply-To: <jwv8tu75ze2.fsf-monnier+bug#24340@gnu.org> (message from Stefan Monnier on Sat, 01 Oct 2016 21:11:34 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: 24340@debbugs.gnu.org
> Date: Sat, 01 Oct 2016 21:11:34 -0400
> 
> > Since I believe master will be used for 25.2, we cannot currently push
> > anything that must wait for 26.
> 
> Now that master has been labeled "for 26.1", can we push a patch to it?
> I'd happily push my patch to it, but if you prefer a different approach,
> feel free to push another patch there instead.

I'm okay with your patch only if you promise to be there for fixing
any fallout.  It scares me quite a lot, especially the fact that it
fixes a single use case by making broad changes across the board.

Once again, my suggestion is instead to announce a change in the
entire buffer, as that is what revert-buffer is all about.





  reply	other threads:[~2016-10-02  7:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30 18:42 bug#24340: insert-file-contents calls before-change-functions too late Stefan Monnier
2016-08-30 19:10 ` Eli Zaretskii
2016-08-30 21:21   ` Stefan Monnier
2016-08-31 14:22     ` Eli Zaretskii
2016-08-31 14:48       ` Stefan Monnier
2016-08-31 15:03         ` Eli Zaretskii
2016-08-31 17:50           ` Stefan Monnier
2016-10-02  1:11           ` Stefan Monnier
2016-10-02  7:19             ` Eli Zaretskii [this message]
2016-10-03 13:48               ` Stefan Monnier
2016-10-03 14:13                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83vaxbjk0m.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=24340@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).