From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails Date: Fri, 09 Dec 2016 10:22:58 +0200 Message-ID: <83vauth5p9.fsf@gnu.org> References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> <83pol8l62j.fsf@gnu.org> <87shpxelkj.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1481271917 11363 195.159.176.226 (9 Dec 2016 08:25:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Dec 2016 08:25:17 +0000 (UTC) Cc: 25088@debbugs.gnu.org To: npostavs@users.sourceforge.net, Stefan Monnier , Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 09 09:25:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFGUR-0001kN-3o for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Dec 2016 09:25:11 +0100 Original-Received: from localhost ([::1]:45271 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFGUU-0001iw-Qi for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Dec 2016 03:25:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFGSP-0004Nl-2w for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2016 03:23:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFGSL-00038A-Tf for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2016 03:23:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48018) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cFGSL-000381-Q2 for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2016 03:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cFGSL-0007Kn-I1 for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2016 03:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Dec 2016 08:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25088 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25088-submit@debbugs.gnu.org id=B25088.148127176028158 (code B ref 25088); Fri, 09 Dec 2016 08:23:01 +0000 Original-Received: (at 25088) by debbugs.gnu.org; 9 Dec 2016 08:22:40 +0000 Original-Received: from localhost ([127.0.0.1]:35184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFGS0-0007K6-3I for submit@debbugs.gnu.org; Fri, 09 Dec 2016 03:22:40 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFGRy-0007Jr-Ah for 25088@debbugs.gnu.org; Fri, 09 Dec 2016 03:22:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFGRs-0002rw-BK for 25088@debbugs.gnu.org; Fri, 09 Dec 2016 03:22:33 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFGRs-0002rs-8G; Fri, 09 Dec 2016 03:22:32 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3387 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cFGRq-00074o-K2; Fri, 09 Dec 2016 03:22:31 -0500 In-reply-to: <87shpxelkj.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126767 Archived-At: > From: npostavs@users.sourceforge.net > Cc: 25088@debbugs.gnu.org > Date: Fri, 09 Dec 2016 00:08:28 -0500 > > > If this means there could be another, safer way of fixing this, please > > show the details. > > Not sure how much safer this is, I think we would have to record the > which symbol plists are being modified during `load' so that > `unload-feature' could find them in `load-history' and reverse them > along with functions definitions. This would get rid of the > compiler-macro entries that were added to cl-defstruct accessor function > symbols, and so they would load successfully the second time round just > like the first (presumably). It could be safer because it doesn't change cl-defstruct. But it's hard to tell without seeing an implementation. What do others think? Is the patch proposed by Noam safe enough for the release branch? Stefan? Dmitry? Thanks.