From: Eli Zaretskii <eliz@gnu.org>
To: Alex <agrambot@gmail.com>
Cc: 23568@debbugs.gnu.org
Subject: bug#23568: 25.0.94; Mode line menus appear incorrectly in some monitor configurations
Date: Sat, 03 Jun 2017 09:32:12 +0300 [thread overview]
Message-ID: <83vaodbmz7.fsf@gnu.org> (raw)
In-Reply-To: <87shjhopqs.fsf@gmail.com> (message from Alex on Fri, 02 Jun 2017 18:54:03 -0600)
> From: Alex <agrambot@gmail.com>
> Date: Fri, 02 Jun 2017 18:54:03 -0600
> Cc: 23568@debbugs.gnu.org
>
> I fixed up the docstrings to match display-monitor-attributes-list.
Thanks, a few comments below.
> Don't you want to throw an error when x and y are used, but are not
> integers?
If this is supposed to be used as part of mode-line display, then no.
Signaling errors in the middle of redisplay is generally a bad idea,
because they cause another redisplay cycle, which again signals an
error, and Emacs just freezes.
> +(defun display-monitor-attribute (attribute &optional display x y)
> + "Return the value of the ATTRIBUTE of the current monitor.
The doc string should say something about what "the current monitor"
means, or have a link to where that is explained.
> +DISPLAY can be a display name, a terminal name, or a frame.
"Terminal name" or "terminal object"?
> +(defun display-monitor-geometry (&optional display x y)
> + "Return the geometry of the current monitor.
> +DISPLAY can be a display name, a terminal name, or a frame.
Same here, on both counts.
> diff --git a/src/xmenu.c b/src/xmenu.c
> index 2805249164..04d5bde2ba 100644
> --- a/src/xmenu.c
> +++ b/src/xmenu.c
Why is this in xmenu.c? Is the problem unique to X window system?
next prev parent reply other threads:[~2017-06-03 6:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 20:44 bug#23568: 25.0.94; Mode line menus appear incorrectly in some monitor configurations Alex
2016-05-18 21:28 ` Alex
2017-05-28 7:09 ` Alex
2017-05-31 7:14 ` Alex
2017-05-31 9:26 ` martin rudalics
2017-05-31 21:18 ` Alex
2017-06-01 5:39 ` martin rudalics
2017-06-01 20:33 ` Alex
2017-06-01 20:51 ` Alex
2017-06-02 6:10 ` martin rudalics
2017-06-02 7:18 ` Alex
2017-06-02 9:00 ` martin rudalics
2017-06-03 0:54 ` Alex
2017-06-03 6:32 ` Eli Zaretskii [this message]
2017-06-03 19:19 ` Alex
2017-06-04 14:28 ` Eli Zaretskii
2017-06-05 8:03 ` Alex
2017-06-05 15:36 ` Eli Zaretskii
2017-06-05 19:33 ` martin rudalics
2017-06-10 9:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vaodbmz7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23568@debbugs.gnu.org \
--cc=agrambot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).