From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25082: [PATCH] Add support to emacsclient for command-lline options in ALTERNATE_EDITOR/--alternate-editor Date: Sun, 27 Aug 2017 17:55:43 +0300 Message-ID: <83val93vrk.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1503845843 1300 195.159.176.226 (27 Aug 2017 14:57:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 27 Aug 2017 14:57:23 +0000 (UTC) Cc: 25082@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 27 16:57:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlyzt-000815-CD for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Aug 2017 16:57:09 +0200 Original-Received: from localhost ([::1]:32962 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlyzz-0006La-QG for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Aug 2017 10:57:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlyzo-0006LG-VB for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 10:57:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlyzl-00030e-Tz for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 10:57:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49304) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlyzl-00030a-Qw for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 10:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dlyzl-0008B8-In for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 10:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Aug 2017 14:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25082 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25082-submit@debbugs.gnu.org id=B25082.150384576331364 (code B ref 25082); Sun, 27 Aug 2017 14:57:01 +0000 Original-Received: (at 25082) by debbugs.gnu.org; 27 Aug 2017 14:56:03 +0000 Original-Received: from localhost ([127.0.0.1]:57985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlyyo-00089o-OV for submit@debbugs.gnu.org; Sun, 27 Aug 2017 10:56:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlyyn-00089K-5W for 25082@debbugs.gnu.org; Sun, 27 Aug 2017 10:56:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlyye-0002hp-Nu for 25082@debbugs.gnu.org; Sun, 27 Aug 2017 10:55:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlyye-0002hl-KO; Sun, 27 Aug 2017 10:55:52 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2795 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dlyyd-0005fT-FH; Sun, 27 Aug 2017 10:55:52 -0400 In-reply-to: (message from Reuben Thomas on Wed, 23 Aug 2017 23:59:01 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136262 Archived-At: > From: Reuben Thomas > Date: Wed, 23 Aug 2017 23:59:01 +0100 > Cc: 25082@debbugs.gnu.org > > I've modified my patch to cope with this case. Rather than write a > general escaping parser, or even one that just copes with escaping > quotes (likely to be complex and buggy in C; and I couldn't find code I > could easily lift from elsewhere), I simply allow " as a delimiter as > well as space for quotes. Escaping quotes is not supported. > > This suffices to cope with the common case on Windows of needing to > quote a path containing spaces. It also copes with other simple cases. > > Is this sufficient? It could be, but I'm not sure I understand clearly what is supported and what isn't. Could you please add this information to the NEWS entry and in more detail to the user manual? I think having these details in the manual is important regardless. Thanks.