From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29303: 25.2; vc-git-grep should shell-escape FILES Date: Thu, 16 Nov 2017 17:38:20 +0200 Message-ID: <83vaiai68j.fsf@gnu.org> References: <87efoz983o.fsf@gmail.com> <83d14jjv5y.fsf@gnu.org> <87375fpehr.fsf@gmail.com> <837eurjoue.fsf@gnu.org> <87tvxvnvog.fsf@gmail.com> <83y3n7i90b.fsf@gnu.org> <87lgj7nuti.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1510846759 10999 195.159.176.226 (16 Nov 2017 15:39:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 16 Nov 2017 15:39:19 +0000 (UTC) Cc: 29303@debbugs.gnu.org, gus@inodes.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 16 16:39:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFMFw-0002E5-G8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Nov 2017 16:39:08 +0100 Original-Received: from localhost ([::1]:41444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFMG3-0003gT-Ri for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Nov 2017 10:39:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFMFw-0003fZ-AV for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2017 10:39:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFMFq-0006yp-DJ for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2017 10:39:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35044) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eFMFq-0006yB-98 for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2017 10:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eFMFq-0002Pd-2d for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2017 10:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Nov 2017 15:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29303 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29303-submit@debbugs.gnu.org id=B29303.15108467039222 (code B ref 29303); Thu, 16 Nov 2017 15:39:02 +0000 Original-Received: (at 29303) by debbugs.gnu.org; 16 Nov 2017 15:38:23 +0000 Original-Received: from localhost ([127.0.0.1]:43725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFMFD-0002Of-2u for submit@debbugs.gnu.org; Thu, 16 Nov 2017 10:38:23 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFMFB-0002OQ-6W for 29303@debbugs.gnu.org; Thu, 16 Nov 2017 10:38:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eFMF5-0005nm-1G for 29303@debbugs.gnu.org; Thu, 16 Nov 2017 10:38:15 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eFMEv-0005H6-7L; Thu, 16 Nov 2017 10:38:05 -0500 Original-Received: from [176.228.60.248] (port=1842 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eFMEu-0002FN-OO; Thu, 16 Nov 2017 10:38:05 -0500 In-reply-to: <87lgj7nuti.fsf@gmail.com> (message from Robert Pluim on Wed, 15 Nov 2017 21:36:09 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139956 Archived-At: > From: Robert Pluim > Cc: 29303@debbugs.gnu.org, gus@inodes.org > Date: Wed, 15 Nov 2017 21:36:09 +0100 > > > Ah. So we lose support of patterns with embedded whitespace in order > > to support the aliases? Is that desirable? > > That's a good question. Note that interactively entering patterns with > a space is currently a pain, since grep-read-files uses > read-file-name-internal, which attempts to do completion if you type > . So this would presumably only affect people who have changed > grep-files-aliases and have patterns with embedded whitespace. Maybe we should mention this in the doc string (assuming that your proposal indeed fixes the original problem).