From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29334: 25.3; compiled commands don't respect special interactive expressions Date: Fri, 24 Nov 2017 09:58:29 +0200 Message-ID: <83vai09kgq.fsf@gnu.org> References: <87efooz7z8.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1511510430 2013 195.159.176.226 (24 Nov 2017 08:00:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 24 Nov 2017 08:00:30 +0000 (UTC) Cc: 29334@debbugs.gnu.org, vianchielfaura@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 24 09:00:25 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eI8uF-00088F-BJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Nov 2017 09:00:15 +0100 Original-Received: from localhost ([::1]:47686 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eI8uM-00049Z-NW for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Nov 2017 03:00:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eI8u8-00041E-Oz for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 03:00:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eI8u3-0001KK-6C for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 03:00:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45951) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eI8u3-0001Jt-3Z for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 03:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eI8u2-00045o-SH for bug-gnu-emacs@gnu.org; Fri, 24 Nov 2017 03:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Nov 2017 08:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29334-submit@debbugs.gnu.org id=B29334.151151034315631 (code B ref 29334); Fri, 24 Nov 2017 08:00:02 +0000 Original-Received: (at 29334) by debbugs.gnu.org; 24 Nov 2017 07:59:03 +0000 Original-Received: from localhost ([127.0.0.1]:54632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eI8t4-000443-PE for submit@debbugs.gnu.org; Fri, 24 Nov 2017 02:59:02 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eI8t3-00043a-5p for 29334@debbugs.gnu.org; Fri, 24 Nov 2017 02:59:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eI8sx-0000Qu-9x for 29334@debbugs.gnu.org; Fri, 24 Nov 2017 02:58:56 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eI8sr-0000Jo-BA; Fri, 24 Nov 2017 02:58:49 -0500 Original-Received: from [176.228.60.248] (port=2576 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eI8sp-0001sa-P4; Fri, 24 Nov 2017 02:58:48 -0500 In-reply-to: <87efooz7z8.fsf@users.sourceforge.net> (message from Noam Postavsky on Thu, 23 Nov 2017 22:11:23 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140292 Archived-At: > From: Noam Postavsky > Date: Thu, 23 Nov 2017 22:11:23 -0500 > Cc: 29334@debbugs.gnu.org, Allen Li > > > Bisected to a46481370, our old friend "Use lexical-binding". > > How about this: > > >From a8b43e98c592c84957ea304a0dc2d6423af9c5c5 Mon Sep 17 00:00:00 2001 > From: Noam Postavsky > Date: Thu, 23 Nov 2017 21:57:09 -0500 > Subject: [PATCH] Fix command repetition with lexical-binding (Bug#29334) > > `call-interactively' relies on analyzing the source of `interactive' > forms in order to preserve arguments like (region-end) in the command > history, rather than just storing the resulting position. However, > the byte-compiler does not preserve the source of the interactive form > when lexical-binding is in effect, because `call-interactively' would > evaluate the form with dynamic binding in that case. > > To fix this, change `call-interactively' so that it checks compiled > functions for lexical-binding as well. Then the byte-compiler can > preserve the source of interactive forms regardless of the value of > lexical-binding. Thanks. If no objections are voiced to this approach, please push it to the master branch. I think this is too radical for the release branch. P.S. Should this change be reflected in the ELisp manual somehow?