bug#31682: for to tags/emacs-26.2: Add NS style text scale keybindings

bug#31682: for to tags/emacs-26.2: Add NS style text scale keybindings

[Van L]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

Alan Third writes:

> >     ;;
> >     ;; Allow Command-Plus-or-Minus to text-scale fontsize.
> >     ;;

> I’ve attached a patch for this.

I've re-created the patch based on tags/emacs-26.1 for to 26.2.



[-- Attachment #2: 0001-Add-NS-style-text-scale-keybindings.patch --]
[-- Type: text/plain, Size: 1060 bytes --]

From 53670c6fdab102e2790ef7ff3c17bf0899d7e377 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Thu, 31 May 2018 21:28:09 +0100
Subject: [PATCH] Add NS style text scale keybindings

* lisp/term/ns-win.el: Add super-based keybindings for adjusting text
zoom.
---
 lisp/term/ns-win.el | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el
index eff8adcd3b..8b23cab010 100644
--- a/lisp/term/ns-win.el
+++ b/lisp/term/ns-win.el
@@ -141,6 +141,10 @@ global-map
 (define-key global-map [?\s-x] 'kill-region)
 (define-key global-map [?\s-y] 'ns-paste-secondary)
 (define-key global-map [?\s-z] 'undo)
+(define-key global-map [?\s-+] 'text-scale-adjust)
+(define-key global-map [?\s-=] 'text-scale-adjust)
+(define-key global-map [?\s--] 'text-scale-adjust)
+(define-key global-map [?\s-0] 'text-scale-adjust)
 (define-key global-map [?\s-|] 'shell-command-on-region)
 (define-key global-map [s-kp-bar] 'shell-command-on-region)
 (define-key global-map [?\C-\s- ] 'ns-do-show-character-palette)
-- 
2.16.1


[-- Attachment #3: 0001-Add-NS-style-text-scale-keybindings-1.patch --]
[-- Type: application/octet-stream, Size: 979 bytes --]

From b149e4608d765cb57093fff2e9534e0a368a0cc8 Mon Sep 17 00:00:00 2001
From: Van Ly <van@scratchspace.com.au>
Date: Sat, 2 Jun 2018 16:28:09 +1000
Subject: [PATCH] Add-NS-style-text-scale-keybindings-1

---
 lisp/term/ns-win.el | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el
index 76b1a41..0c59acf 100644
--- a/lisp/term/ns-win.el
+++ b/lisp/term/ns-win.el
@@ -141,6 +141,10 @@ global-map
 (define-key global-map [?\s-w] 'delete-frame)
 (define-key global-map [?\s-x] 'kill-region)
 (define-key global-map [?\s-y] 'ns-paste-secondary)
+(define-key global-map [?\s-+] 'text-scale-adjust)
+(define-key global-map [?\s-=] 'text-scale-adjust)
+(define-key global-map [?\s--] 'text-scale-adjust)
+(define-key global-map [?\s-0] 'text-scale-adjust)
 (define-key global-map [?\s-z] 'undo)
 (define-key global-map [?\s-|] 'shell-command-on-region)
 (define-key global-map [s-kp-bar] 'shell-command-on-region)
-- 
2.10.1 (Apple Git-78)

bug#31682: for to tags/emacs-26.2: Add NS style text scale keybindings

[Eli Zaretskii]

> Date: Sat, 02 Jun 2018 02:45:28 -0400
> From: Van L <van@scratchspace.com.au>
> 
> Alan Third writes:
> 
> > >     ;;
> > >     ;; Allow Command-Plus-or-Minus to text-scale fontsize.
> > >     ;;
> 
> > I’ve attached a patch for this.
> 
> I've re-created the patch based on tags/emacs-26.1 for to 26.2.

But this is not a bug, is it?  If not, it should go to master, not the
emacs-26 branch.

Thanks.

bug#31682: for to tags/emacs-26.2: Add NS style text scale keybindings

[Van L]

Eli Zaretskii writes:

> But this is not a bug, is it? If not, it should go to master, not the
> 
> emacs-26 branch.

I don't know the relationship between branch 27 and 26.

I assume 26 is a stable conservative uncontroversial branch shadowing 27's unfettered evolution.

The change can be argued as a `UI experience bug fix` since NS style copy, paste, kill keybindings are there and NS style zooming on the fontsize is expected to be, too.

A different perspective would see it as a new feature not bug.

bug#31682: for to tags/emacs-26.2: Add NS style text scale keybindings

[Eli Zaretskii]

> Date: Sat, 02 Jun 2018 04:04:49 -0400
> From: Van L <van@scratchspace.com.au>
> Cc: Alan Third <alan@idiocy.org>, "31682@debbugs.gnu.org" <31682@debbugs.gnu.org>
> Feedback-ID: CZzD_FB3wty_FyuJcLjvdwM27wBazNtT4ncACjM2IIhF0RODvRhWTfVmRC__RsdKPob4nJOCfPmzZRKgdFxGdQ==:Ext:ProtonMail
> 
> Eli Zaretskii writes:
> 
> > But this is not a bug, is it? If not, it should go to master, not the
> > 
> > emacs-26 branch.
> 
> I don't know the relationship between branch 27 and 26.

The emacs-26 branch should only receive bugfixes, i.e. changes that
fix problems in existing code.  New features should go to master,
which will become Emacs 27.1.

bug#31682: for to tags/emacs-26.2: Add NS style text scale keybindings

[Van L]

Eli Zaretskii writes:

> > 
> > I don't know the relationship between branch 27 and 26.
> 
> The emacs-26 branch should only receive bugfixes, i.e. changes that
> 
> fix problems in existing code. New features should go to master,
> 
> which will become Emacs 27.1.

Then Alan T's patch will go in master.

Thanks Eli.

bug#31682: for to tags/emacs-26.2: Add NS style text scale keybindings

[Alan Third]

Van L <van@scratchspace.com.au> writes:

> Eli Zaretskii writes:
>
>> > 
>> > I don't know the relationship between branch 27 and 26.
>> 
>> The emacs-26 branch should only receive bugfixes, i.e. changes that
>> 
>> fix problems in existing code. New features should go to master,
>> 
>> which will become Emacs 27.1.
>
> Then Alan T's patch will go in master.

Pushed it to master.

-- 
Alan Third