unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree
@ 2018-06-28 19:10 Noam Postavsky
  2018-06-28 19:18 ` Eli Zaretskii
  2018-06-28 20:55 ` Paul Eggert
  0 siblings, 2 replies; 12+ messages in thread
From: Noam Postavsky @ 2018-06-28 19:10 UTC (permalink / raw)
  To: 31996; +Cc: paul eggert

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

X-Debbugs-CC: Paul Eggert <eggert@cs.ucla.edu>


gdb --args ./temacs --batch  --load loadup bootstrap

(gdb) p specpdl_ptr->kind
$1 = SPECPDL_UNWIND_ARRAY
(gdb) p specpdl_ptr->unwind_ptr.func
$2 = (void (*)(void *)) 0x53898
(gdb) p specpdl_ptr->unwind_array.func
$3 = (void (*)(Lisp_Object)) 0x53898

I guess it's related to the #31750 changes. The problem doesn't seem
especially platform-specific, but I've haven't seen this on my
GNU/Linux box.
The attached patch fixes it, though I'm not sure if it's
entirely correct.

[-- Attachment #2: unwind-array.diff --]
[-- Type: application/octet-stream, Size: 986 bytes --]

--- i/src/lisp.h
+++ w/src/lisp.h
@@ -4543,7 +4543,8 @@ safe_free (ptrdiff_t sa_count)
   while (specpdl_ptr != specpdl + sa_count)
     {
       specpdl_ptr--;
-      eassert ((specpdl_ptr->kind == SPECPDL_UNWIND_PTR || specpdl_ptr->kind == SPECPDL_UNWIND_ARRAY)
+      eassert ((specpdl_ptr->kind == SPECPDL_UNWIND_PTR
+                || specpdl_ptr->kind == SPECPDL_UNWIND_ARRAY)
 	       && specpdl_ptr->unwind_ptr.func == xfree);
       xfree (specpdl_ptr->unwind_ptr.arg);
     }
diff --git i/src/w32fns.c w/src/w32fns.c
index 3bd3209..59edb31 100644
--- i/src/w32fns.c
+++ w/src/w32fns.c
@@ -4551,7 +4551,7 @@ w32_wnd_proc (HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
 	 dialog boxes, such as the file selection dialog or font
 	 selection dialog.  So something else is needed to fix the
 	 former without breaking the latter.  See bug#11732.  */
-      break;
+      goto dflt;
 
     case WM_IME_ENDCOMPOSITION:
       ignore_ime_char = 0;



^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-06-29 18:18 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-28 19:10 bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree Noam Postavsky
2018-06-28 19:18 ` Eli Zaretskii
2018-06-28 19:20   ` Noam Postavsky
2018-06-28 20:29     ` Andy Moreton
2018-06-28 20:55 ` Paul Eggert
2018-06-28 21:05   ` Noam Postavsky
2018-06-28 22:57     ` Paul Eggert
2018-06-29  6:13       ` Eli Zaretskii
2018-06-29  7:30         ` Paul Eggert
2018-06-29  8:52           ` Eli Zaretskii
2018-06-29 12:30       ` Noam Postavsky
2018-06-29 18:18         ` Paul Eggert

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).