From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33618: better fix Date: Sat, 20 Apr 2019 20:24:35 +0300 Message-ID: <83v9z8a8to.fsf@gnu.org> References: <86d0lg8vyk.fsf@stephe-leake.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="189171"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33618@debbugs.gnu.org To: Stephen Leake Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 20 19:30:29 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHtor-000n7p-CG for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Apr 2019 19:30:29 +0200 Original-Received: from localhost ([127.0.0.1]:43688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHtoq-0001PH-93 for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Apr 2019 13:30:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHtoC-0000yD-MY for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 13:29:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHtkY-0008Nm-A2 for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 13:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33153) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHtkY-0008Nc-71 for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 13:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hHtkX-0001YO-Qz for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 13:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Apr 2019 17:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33618 X-GNU-PR-Package: emacs Original-Received: via spool by 33618-submit@debbugs.gnu.org id=B33618.15557811025866 (code B ref 33618); Sat, 20 Apr 2019 17:26:01 +0000 Original-Received: (at 33618) by debbugs.gnu.org; 20 Apr 2019 17:25:02 +0000 Original-Received: from localhost ([127.0.0.1]:46697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHtjZ-0001WO-SU for submit@debbugs.gnu.org; Sat, 20 Apr 2019 13:25:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHtjY-0001W7-5h for 33618@debbugs.gnu.org; Sat, 20 Apr 2019 13:25:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHtjQ-0007bW-Pv; Sat, 20 Apr 2019 13:24:53 -0400 Original-Received: from [176.228.60.248] (port=2386 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hHtjN-0004Hi-5r; Sat, 20 Apr 2019 13:24:50 -0400 In-reply-to: <86d0lg8vyk.fsf@stephe-leake.org> (message from Stephen Leake on Sat, 20 Apr 2019 08:47:47 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157909 Archived-At: > From: Stephen Leake > Date: Sat, 20 Apr 2019 08:47:47 -0800 > > `grep-mode' is defined by `define-compilation-mode', which sets > `compilation-search-path' to a buffer-local copy of `grep-search-path', > if the latter is defined. > > So there is precedent for making custom vars buffer-local, and it seems > the proper fix for this bug is to define `grep-search-path': Please don't forget :version tags of new defcustoms, and also they should be called out in NEWS. Thanks.