From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32257: 26.1; read-multiple-choice inf loops on mouse clicks Date: Wed, 22 May 2019 13:08:47 +0300 Message-ID: <83v9y27qds.fsf@gnu.org> References: <87muug4z52.fsf@gmail.com> <87y3dy3i05.fsf@gmail.com> <83muudrqol.fsf@gnu.org> <83effosvx2.fsf@gnu.org> <87r2jo3l0w.fsf@gmail.com> <837elgss8l.fsf@gnu.org> <87sh40189j.fsf@gmail.com> <83zhy7o0i0.fsf@gnu.org> <83h8keodsi.fsf@gnu.org> <87ftp79up9.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="140274"; mail-complaints-to="usenet@blaine.gmane.org" Cc: andrewjmoreton@gmail.com, 32257@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 22 12:09:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTOBQ-000aMe-PS for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2019 12:09:16 +0200 Original-Received: from localhost ([127.0.0.1]:39572 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTOBP-0003OL-M2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 May 2019 06:09:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTOBD-0003N3-JE for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:09:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hTOBC-0004wv-OX for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56280) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hTOBC-0004wk-L3 for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hTOBC-0004OU-C5 for bug-gnu-emacs@gnu.org; Wed, 22 May 2019 06:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 May 2019 10:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32257-submit@debbugs.gnu.org id=B32257.155851972716867 (code B ref 32257); Wed, 22 May 2019 10:09:02 +0000 Original-Received: (at 32257) by debbugs.gnu.org; 22 May 2019 10:08:47 +0000 Original-Received: from localhost ([127.0.0.1]:41591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTOAx-0004Nz-BJ for submit@debbugs.gnu.org; Wed, 22 May 2019 06:08:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hTOAv-0004Nn-Ft for 32257@debbugs.gnu.org; Wed, 22 May 2019 06:08:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTOAq-0004hU-Cf; Wed, 22 May 2019 06:08:40 -0400 Original-Received: from [176.228.60.248] (port=4217 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hTOAp-0003rS-O0; Wed, 22 May 2019 06:08:40 -0400 In-reply-to: <87ftp79up9.fsf@gmail.com> (message from Noam Postavsky on Tue, 21 May 2019 20:52:34 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159640 Archived-At: > From: Noam Postavsky > Date: Tue, 21 May 2019 20:52:34 -0400 > Cc: 32257@debbugs.gnu.org > > >> Fixing a problem and introducing another doesn't sound wise to me. > >> We've been there several times during the last years, and I don't want > >> to make the same mistake again. Sorry. > > > > Perhaps reverting the patches that introduced read-multiple-choice > > is the right answer then. > > How about for emacs-26, we call read-event only after receiving the > problematic error. This works around the problem, and should be safe > enough, since it only triggers when we would otherwise be ending up in > an infloop anyway. SGTM, thanks.