From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373) Date: Fri, 03 Jan 2020 20:44:26 +0200 Message-ID: <83v9psgz1x.fsf@gnu.org> References: <20191226000417.69183-1-phst@google.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="247328"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 30373@debbugs.gnu.org, sjindel@google.com To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 03 19:45:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1inRwc-0012Aj-Qm for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2020 19:45:10 +0100 Original-Received: from localhost ([::1]:55716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inRwb-0007vV-Lg for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2020 13:45:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56153) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inRwV-0007vI-Iw for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 13:45:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inRwU-0007wA-H6 for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 13:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35469) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inRwU-0007u7-8m for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 13:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1inRwU-0003Od-6O for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 13:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2020 18:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30373 X-GNU-PR-Package: emacs Original-Received: via spool by 30373-submit@debbugs.gnu.org id=B30373.157807707413009 (code B ref 30373); Fri, 03 Jan 2020 18:45:02 +0000 Original-Received: (at 30373) by debbugs.gnu.org; 3 Jan 2020 18:44:34 +0000 Original-Received: from localhost ([127.0.0.1]:41442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inRw1-0003Nl-Vk for submit@debbugs.gnu.org; Fri, 03 Jan 2020 13:44:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inRw0-0003NZ-Rg for 30373@debbugs.gnu.org; Fri, 03 Jan 2020 13:44:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inRvv-0005EC-JO; Fri, 03 Jan 2020 13:44:27 -0500 Original-Received: from [176.228.60.248] (port=2402 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inRvu-0008CB-SX; Fri, 03 Jan 2020 13:44:27 -0500 In-reply-to: (message from Philipp Stephani on Fri, 3 Jan 2020 19:34:51 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174129 Archived-At: > From: Philipp Stephani > Date: Fri, 3 Jan 2020 19:34:51 +0100 > Cc: Philipp Stephani > > Since there were no objections, I've installed this patch (plus some > documentation) as commit 48ffef5ef4 into master. Thanks. The new test fails for me on MS-Windows: Test module/function-finalizer backtrace: signal(ert-test-failed (((should (equal (mod-test-function-finalizer ert-fail(((should (equal (mod-test-function-finalizer-calls) expecte (if (unwind-protect (setq value-370 (apply fn-368 args-369)) (setq f (let (form-description-372) (if (unwind-protect (setq value-370 (app (let ((value-370 'ert-form-evaluation-aborted-371)) (let (form-descr (let* ((fn-368 #'equal) (args-369 (condition-case err (let ((signal- (let* ((previous-calls (mod-test-function-finalizer-calls)) (expecte (closure (t) nil (mod-test-make-function-with-finalizer) (let* ((pre ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name module/function-finalizer :documentat ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charset cp86 command-line() normal-top-level() Test module/function-finalizer condition: (ert-test-failed ((should (equal (mod-test-function-finalizer-calls) expected-calls)) :form (equal (0 0) (1 0)) :value nil :explanation (list-elt 0 (different-atoms (0 "#x0" "?