From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41370: 27.0.91; Eshell and exit-minibuffer Date: Wed, 20 May 2020 21:04:39 +0300 Message-ID: <83v9kq5vpk.fsf@gnu.org> References: <875zcui7m4.fsf@gmail.com> <85k116o6n3.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="84884"; mail-complaints-to="usenet@ciao.gmane.io" Cc: andremegafone@gmail.com, alex.branham@gmail.com, 41370@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 20 20:05:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbT5g-000LzS-5G for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 20:05:16 +0200 Original-Received: from localhost ([::1]:56242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbT5f-0000Ac-7F for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 14:05:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbT5S-00008z-EY for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 14:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbT5S-000377-5M for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 14:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbT5R-0004Q2-VZ for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 14:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 May 2020 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41370 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 41370-submit@debbugs.gnu.org id=B41370.158999790116976 (code B ref 41370); Wed, 20 May 2020 18:05:01 +0000 Original-Received: (at 41370) by debbugs.gnu.org; 20 May 2020 18:05:01 +0000 Original-Received: from localhost ([127.0.0.1]:54218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbT5C-0004PV-6E for submit@debbugs.gnu.org; Wed, 20 May 2020 14:05:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbT5B-0004PH-4T for 41370@debbugs.gnu.org; Wed, 20 May 2020 14:04:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54906) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbT55-00034X-TV; Wed, 20 May 2020 14:04:39 -0400 Original-Received: from [176.228.60.248] (port=4108 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jbT54-0006yy-Ok; Wed, 20 May 2020 14:04:39 -0400 In-Reply-To: <85k116o6n3.fsf@gmail.com> (message from Noam Postavsky on Wed, 20 May 2020 13:31:12 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180681 Archived-At: > From: Noam Postavsky > Date: Wed, 20 May 2020 13:31:12 -0400 > Cc: Alex Branham , 41370@debbugs.gnu.org > > This is because eshell-command calls eshell-return-exits-minibuffer > which does > > (define-key eshell-mode-map [(control ?m)] 'exit-minibuffer) > > This was okay in 26.3 because eshell-mode created its keymap from > scratch every time. That's no longer the case since [1: 1ee0192b792] > (bugs #22792 and #33808). > > [1: 1ee0192b792]: 2019-08-15 20:49:15 -0400 > Fix eshell-mode-map initialization > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1ee0192b792124663a0a40a729dd83c047d21535 > > I think that should be reverted from emacs-27, and the patch below can > fix it for master: Agreed, thanks.