From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: andremegafone@gmail.com, alex.branham@gmail.com, 41370@debbugs.gnu.org
Subject: bug#41370: 27.0.91; Eshell and exit-minibuffer
Date: Wed, 20 May 2020 21:04:39 +0300 [thread overview]
Message-ID: <83v9kq5vpk.fsf@gnu.org> (raw)
In-Reply-To: <85k116o6n3.fsf@gmail.com> (message from Noam Postavsky on Wed, 20 May 2020 13:31:12 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Wed, 20 May 2020 13:31:12 -0400
> Cc: Alex Branham <alex.branham@gmail.com>, 41370@debbugs.gnu.org
>
> This is because eshell-command calls eshell-return-exits-minibuffer
> which does
>
> (define-key eshell-mode-map [(control ?m)] 'exit-minibuffer)
>
> This was okay in 26.3 because eshell-mode created its keymap from
> scratch every time. That's no longer the case since [1: 1ee0192b792]
> (bugs #22792 and #33808).
>
> [1: 1ee0192b792]: 2019-08-15 20:49:15 -0400
> Fix eshell-mode-map initialization
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1ee0192b792124663a0a40a729dd83c047d21535
>
> I think that should be reverted from emacs-27, and the patch below can
> fix it for master:
Agreed, thanks.
next prev parent reply other threads:[~2020-05-20 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 21:17 bug#41370: 27.0.91; Eshell and exit-minibuffer André Alexandre Gomes
2020-05-20 17:31 ` Noam Postavsky
2020-05-20 18:04 ` Eli Zaretskii [this message]
2020-05-25 0:28 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v9kq5vpk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=41370@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
--cc=andremegafone@gmail.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).