From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44611: Prefix arg for xref-goto-xref Date: Sun, 20 Dec 2020 17:43:32 +0200 Message-ID: <83v9cwsct7.fsf@gnu.org> References: <87k0up68e4.fsf@mail.linkov.net> <99772eb6-5a4e-7cf6-259d-0e9429e6bf97@yandex.ru> <878sb3n0a9.fsf@mail.linkov.net> <48f942f9-a557-0185-25fe-612e78cd9071@yandex.ru> <875z67gd6z.fsf@mail.linkov.net> <72e9e5e9-651f-401f-2e26-faaac1b7fdb5@yandex.ru> <87v9cxleff.fsf@mail.linkov.net> <834kkhtaxm.fsf@gnu.org> <874kkgswg2.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="644"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 20 16:44:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kr0sS-000AdI-Jj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Dec 2020 16:44:08 +0100 Original-Received: from localhost ([::1]:42488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kr0sR-0001Va-Hf for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Dec 2020 10:44:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr0sM-0001VR-6o for bug-gnu-emacs@gnu.org; Sun, 20 Dec 2020 10:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kr0sL-0000Im-V2 for bug-gnu-emacs@gnu.org; Sun, 20 Dec 2020 10:44:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kr0sL-0007iB-SJ for bug-gnu-emacs@gnu.org; Sun, 20 Dec 2020 10:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Dec 2020 15:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44611 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44611-submit@debbugs.gnu.org id=B44611.160847903729623 (code B ref 44611); Sun, 20 Dec 2020 15:44:01 +0000 Original-Received: (at 44611) by debbugs.gnu.org; 20 Dec 2020 15:43:57 +0000 Original-Received: from localhost ([127.0.0.1]:45375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr0sH-0007hj-9I for submit@debbugs.gnu.org; Sun, 20 Dec 2020 10:43:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr0sF-0007hU-26 for 44611@debbugs.gnu.org; Sun, 20 Dec 2020 10:43:55 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47701) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kr0s9-0000Eg-Hc; Sun, 20 Dec 2020 10:43:49 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3637 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kr0s8-00052U-VW; Sun, 20 Dec 2020 10:43:49 -0500 In-Reply-To: <874kkgswg2.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 20 Dec 2020 10:39:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196475 Archived-At: > From: Juri Linkov > Cc: dgutov@yandex.ru, joaotavora@gmail.com, 44611@debbugs.gnu.org > Date: Sun, 20 Dec 2020 10:39:25 +0200 > > >> Therefore, I propose this patch that binds TAB and S-TAB to command > >> that behave like compilation-next-error and compilation-previous-error: > > > > This is an incompatible behavior change, no? If so, I'm not sure we > > can simply make it. > > This is what we have the section "Incompatible Editing Changes" in etc/NEWS for. The fact that the section exists doesn't mean we can make incompatible changes whenever we feel like. This key binding existed since Emacs 26.1, so changing it would definitely surprise someone. > And since the new keybinding have no disastrous effect, it would safer > for the users to adapt to the new keybinding. What disastrous effects? AFAICT, TAB buries the XREF buffer, which is not a disaster. More generally, I think it's wrong to try to make XREF buffers behave like *Grep* buffers. They are different beasts, I think we established this long ago, when Xref was added to Emacs (I think I even made a comment regarding the difference, and Dmitry responded to the effect that this was intended). *XREF* and *Grep* look differently and behave differently, and it's impossible to make them be similar enough. So I'm against this change, certainly if it's unconditionally changes the key binding.