From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45748: 28.0.50; fit-frame-to-buffer ignores leading spaces Date: Fri, 15 Jan 2021 14:11:27 +0200 Message-ID: <83v9by9z80.fsf@gnu.org> References: <01d09a7b-09b0-9221-5bf3-8454f94704f7@gmx.at> <83k0smgeq8.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31356"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45748@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 15 13:12:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0Nxq-00081G-Nr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 13:12:26 +0100 Original-Received: from localhost ([::1]:54164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0Nxp-0004YY-P9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 07:12:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0NxT-0004GM-3A for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 07:12:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0NxS-0006Br-6n for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 07:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0NxS-0005xF-1t for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 07:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jan 2021 12:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45748 X-GNU-PR-Package: emacs Original-Received: via spool by 45748-submit@debbugs.gnu.org id=B45748.161071270622867 (code B ref 45748); Fri, 15 Jan 2021 12:12:01 +0000 Original-Received: (at 45748) by debbugs.gnu.org; 15 Jan 2021 12:11:46 +0000 Original-Received: from localhost ([127.0.0.1]:40062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0NxC-0005wl-21 for submit@debbugs.gnu.org; Fri, 15 Jan 2021 07:11:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0NxA-0005wZ-E4 for 45748@debbugs.gnu.org; Fri, 15 Jan 2021 07:11:45 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51726) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0Nwz-000620-3k; Fri, 15 Jan 2021 07:11:33 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4199 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l0Nwx-0004nN-UN; Fri, 15 Jan 2021 07:11:32 -0500 In-Reply-To: (message from Aaron Jensen on Sat, 9 Jan 2021 20:56:35 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197982 Archived-At: > From: Aaron Jensen > Date: Sat, 9 Jan 2021 20:56:35 -0600 > Cc: martin rudalics , 45748@debbugs.gnu.org > > Let me know how this looks and if you want me to make any tweaks. Thanks, I installed this on the master branch. However, the new tests fail for me in batch execution on MS-Windows with this error: Test xdisp-tests--window-text-pixel-size condition: (error "Not using an ASCII terminal now; cannot make a new ASCII frame") It works if I run the test interactively. The backtrace is make-terminal-frame(((parent-frame . #))) tty-create-frame-with-faces(((parent-frame . #))) #f(compiled-function (params) #)(((paren apply(#f(compiled-function (params) #) ( frame-creation-function(((parent-frame . #))) make-frame(((parent-frame . #))) display-buffer-in-child-frame(# nil) display-buffer(# (display-buffer-in-child-frame)) (let* ((window (display-buffer (current-buffer) '(display-buffer-in- (progn (insert "xx ") (let* ((window (display-buffer (current-buffer (unwind-protect (progn (insert "xx ") (let* ((window (display-buffer (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current (closure (t) nil (let ((temp-buffer (generate-new-buffer " *temp*" t ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name xdisp-tests--window-text-pixel-size-t ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) I guess you are assuming some functionality that isn't supported on all platforms? Can you please rewrite the tests so that they work on all platforms? Thanks.