From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 45748@debbugs.gnu.org
Subject: bug#45748: 28.0.50; fit-frame-to-buffer ignores leading spaces
Date: Fri, 15 Jan 2021 14:11:27 +0200 [thread overview]
Message-ID: <83v9by9z80.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48zBAA6b7h5iVV+zFxo-EzyQ3wLGmGn4AfpdTZPJMh7kJQ@mail.gmail.com> (message from Aaron Jensen on Sat, 9 Jan 2021 20:56:35 -0600)
> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Sat, 9 Jan 2021 20:56:35 -0600
> Cc: martin rudalics <rudalics@gmx.at>, 45748@debbugs.gnu.org
>
> Let me know how this looks and if you want me to make any tweaks.
Thanks, I installed this on the master branch.
However, the new tests fail for me in batch execution on MS-Windows
with this error:
Test xdisp-tests--window-text-pixel-size condition:
(error "Not using an ASCII terminal now; cannot make a new ASCII frame")
It works if I run the test interactively.
The backtrace is
make-terminal-frame(((parent-frame . #<frame F1 062dca38>)))
tty-create-frame-with-faces(((parent-frame . #<frame F1 062dca38>)))
#f(compiled-function (params) #<bytecode 0x6bc24af6be4b5d2>)(((paren
apply(#f(compiled-function (params) #<bytecode 0x6bc24af6be4b5d2>) (
frame-creation-function(((parent-frame . #<frame F1 062dca38>)))
make-frame(((parent-frame . #<frame F1 062dca38>)))
display-buffer-in-child-frame(#<killed buffer> nil)
display-buffer(#<killed buffer> (display-buffer-in-child-frame))
(let* ((window (display-buffer (current-buffer) '(display-buffer-in-
(progn (insert "xx ") (let* ((window (display-buffer (current-buffer
(unwind-protect (progn (insert "xx ") (let* ((window (display-buffer
(save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
(let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
(closure (t) nil (let ((temp-buffer (generate-new-buffer " *temp*" t
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xdisp-tests--window-text-pixel-size-t
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
I guess you are assuming some functionality that isn't supported on
all platforms? Can you please rewrite the tests so that they work on
all platforms?
Thanks.
next prev parent reply other threads:[~2021-01-15 12:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 15:43 bug#45748: 28.0.50; fit-frame-to-buffer ignores leading spaces Aaron Jensen
2021-01-09 15:57 ` Aaron Jensen
2021-01-09 16:27 ` Aaron Jensen
2021-01-09 17:07 ` martin rudalics
2021-01-09 17:44 ` Aaron Jensen
2021-01-09 17:55 ` Aaron Jensen
2021-01-09 18:14 ` Eli Zaretskii
2021-01-10 2:56 ` Aaron Jensen
2021-01-10 16:05 ` martin rudalics
2021-01-10 17:31 ` Aaron Jensen
2021-01-10 17:49 ` martin rudalics
2021-01-10 17:51 ` Aaron Jensen
2021-01-10 17:57 ` martin rudalics
2021-01-10 17:58 ` Aaron Jensen
2021-01-13 4:34 ` Aaron Jensen
2021-01-13 14:26 ` Eli Zaretskii
2021-01-15 12:11 ` Eli Zaretskii [this message]
2021-01-15 12:34 ` Aaron Jensen
2021-01-15 13:15 ` Eli Zaretskii
2021-01-15 14:04 ` Aaron Jensen
2021-01-15 15:37 ` Eli Zaretskii
2021-01-15 17:03 ` Aaron Jensen
2021-01-09 18:03 ` Eli Zaretskii
2021-01-09 17:44 ` Eli Zaretskii
2021-01-09 17:49 ` Aaron Jensen
2021-01-09 17:07 ` martin rudalics
2021-01-16 17:12 ` bug#45748: [PATCH] * test/src/xdisp-tests.el Fix tests to work in batch mode Aaron Jensen
2021-01-16 17:57 ` Basil L. Contovounesios
2021-01-16 18:24 ` Aaron Jensen
2021-01-16 18:24 ` Aaron Jensen
2021-01-16 18:28 ` Aaron Jensen
2021-01-16 18:28 ` Aaron Jensen
2021-01-16 18:33 ` Eli Zaretskii
2021-01-18 17:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v9by9z80.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=45748@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).