From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45934: native-comp - Dylib ID of ELN files not optimal Date: Fri, 29 Jan 2021 09:09:29 +0200 Message-ID: <83v9bgxlqu.fsf@gnu.org> References: <34A641C2-F9E7-487F-8998-D0BC416402FB@yahoo.it> <14FA30A6-E8CC-4A7D-9F40-954515F814D9@yahoo.it> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7164"; mail-complaints-to="usenet@ciao.gmane.io" Cc: davide.restivo@yahoo.it, 45934@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 29 08:10:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5Nv1-0001kM-90 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Jan 2021 08:10:11 +0100 Original-Received: from localhost ([::1]:57514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5Nv0-0000pa-1B for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Jan 2021 02:10:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5Nus-0000pD-27 for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 02:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5Nur-0000JN-RG for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 02:10:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l5Nur-0006i4-MW for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2021 02:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jan 2021 07:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45934 X-GNU-PR-Package: emacs Original-Received: via spool by 45934-submit@debbugs.gnu.org id=B45934.161190416025736 (code B ref 45934); Fri, 29 Jan 2021 07:10:01 +0000 Original-Received: (at 45934) by debbugs.gnu.org; 29 Jan 2021 07:09:20 +0000 Original-Received: from localhost ([127.0.0.1]:51015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5NuC-0006h2-8g for submit@debbugs.gnu.org; Fri, 29 Jan 2021 02:09:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5NuA-0006gq-Gf for 45934@debbugs.gnu.org; Fri, 29 Jan 2021 02:09:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33579) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5Nu4-00080m-SQ; Fri, 29 Jan 2021 02:09:12 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1501 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l5Nu4-0000QS-4o; Fri, 29 Jan 2021 02:09:12 -0500 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198851 Archived-At: > Date: Thu, 28 Jan 2021 21:59:16 +0000 > Cc: 45934@debbugs.gnu.org > From: akrl--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > +/* On MacOS set a unique dylib ID (Bug#45934). */ > +#if defined (LIBGCCJIT_HAVE_gcc_jit_context_add_driver_option) \ > + && defined (DARWIN_OS) > + gcc_jit_context_add_driver_option ( > + comp.ctxt, > + SSDATA (concat2 (build_string ("-install_name "), > + Ffile_name_nondirectory (filename)))); > +#endif A minor nit unrelated to the issue at hand: if you take care to mention the bug number in the commit log message, there's no need to do that in the comments. In general, I don't think it's a good idea to have our sources full of references to bug reports; if the comment by itself doesn't explain the underlying issue, it is better to enhance the comment to be self-contained. IMO, a reference to a bug in the comments is only justified when the issue is so complicated to explain that having such an explanation in comments is impractical. TIA