unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: 46036@debbugs.gnu.org, riccardo.mottola@libero.it
Subject: bug#46036: fails do build on macos 10.7
Date: Sat, 30 Jan 2021 14:05:05 +0200	[thread overview]
Message-ID: <83v9be8wb2.fsf@gnu.org> (raw)
In-Reply-To: <YBU7ey17QCydZ7yF@breton.holly.idiocy.org> (message from Alan Third on Sat, 30 Jan 2021 10:56:59 +0000)

> Date: Sat, 30 Jan 2021 10:56:59 +0000
> From: Alan Third <alan@idiocy.org>
> Cc: Riccardo Mottola <riccardo.mottola@libero.it>, 46036@debbugs.gnu.org
> 
> On Sat, Jan 30, 2021 at 10:57:20AM +0200, Eli Zaretskii wrote:
> > > Date: Fri, 22 Jan 2021 15:57:18 +0100
> > > From: Riccardo Mottola <riccardo.mottola@libero.it>
> > > 
> > > Compilation of 27.1 yields:
> > > nsfns.m:496:33: error: unexpected type name 'BOOL': expected expression
> > >    NSNumber *isUbiquitousItem = @YES;
> > >                                  ^
> > > /usr/include/objc/objc.h:50:26: note: expanded from macro 'YES'
> > > #define YES             (BOOL)1
> > >                           ^
> > > 
> > > this code is guarded with MacOS 10.7, but the compiler doesn't like it.
> > > 
> > > It is as easy to write it old-style:
> > >    NSNumber *isUbiquitousItem = [NSNumber numberWithBool:YES];
> > > 
> > > and emacs 27.1 happily running on Lion again.
> > 
> > Alan, any comments on this?
> 
> Looks fine to me. Is this good to go into Emacs 27, or does it have to
> wait until the release is done?

Please push to emacs-27.

Is this change safe, or will we need another pretest to be sure?  I
thought we could next go straight to a release candidate.

Thanks.





  reply	other threads:[~2021-01-30 12:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 14:57 bug#46036: fails do build on macos 10.7 Riccardo Mottola
2021-01-30  8:57 ` Eli Zaretskii
2021-01-30 10:56   ` Alan Third
2021-01-30 12:05     ` Eli Zaretskii [this message]
2021-01-30 18:32       ` Riccardo Mottola
2021-01-30 18:34         ` Eli Zaretskii
2021-01-30 22:15           ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v9be8wb2.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=46036@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    --cc=riccardo.mottola@libero.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).