From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45379: 28.0.50; Degraded Performance of describe-buffer-bindings Date: Sat, 06 Mar 2021 10:15:16 +0200 Message-ID: <83v9a4wve3.fsf@gnu.org> References: <02f717c6-dc96-4ba0-9117-2ef079ac556f@www.fastmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30765"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri@linkov.net, styang@fastmail.com, stephen.berman@gmx.net, monnier@iro.umontreal.ca, 45379@debbugs.gnu.org To: Stefan Kangas , Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 06 09:16:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIS6t-0007tU-Le for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 09:16:27 +0100 Original-Received: from localhost ([::1]:35068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIS6s-0005wX-MR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 03:16:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIS6X-0005wF-KJ for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 03:16:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIS6U-0001Xh-PS for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 03:16:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIS6U-0005ej-M8 for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 03:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Mar 2021 08:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45379 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 45379-submit@debbugs.gnu.org id=B45379.161501854421697 (code B ref 45379); Sat, 06 Mar 2021 08:16:02 +0000 Original-Received: (at 45379) by debbugs.gnu.org; 6 Mar 2021 08:15:44 +0000 Original-Received: from localhost ([127.0.0.1]:35961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIS67-0005do-PT for submit@debbugs.gnu.org; Sat, 06 Mar 2021 03:15:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIS65-0005da-JK for 45379@debbugs.gnu.org; Sat, 06 Mar 2021 03:15:38 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34947) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIS5z-00019C-CQ; Sat, 06 Mar 2021 03:15:31 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4618 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lIS5y-0004tb-BN; Sat, 06 Mar 2021 03:15:30 -0500 In-Reply-To: (message from Stefan Kangas on Fri, 5 Mar 2021 20:44:33 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201599 Archived-At: > From: Stefan Kangas > Date: Fri, 5 Mar 2021 20:44:33 -0800 > Cc: Juri Linkov , martin rudalics , Eli Zaretskii , > 45379@debbugs.gnu.org, Stefan Monnier , > Stephen Berman > > It turns out that we were doing unnecessary looping due to the above > mentioned commit. While working on this, I also found that we can get > rid of an unnecessary call to char_table_ref_and_range, which should > make this function run even faster. I'm not sure I understand the reasons for each of the changes here. char-tables are a tricky data structure, so I'd like to make sure this change doesn't make our code subtly incorrect. So could you please walk us through the proposed changes, adding explanations for each part as you go? (And what do char-tables have to do with describing key bindings, btw?) > I'm also copying in Kenichi Handa, who was the last to touch this code. > Handa-san, please let us know if you have any comments on this patch. > Thanks in advance. AFAICT, you didn't CC Kenichi; I have now added him to the discussion. Thanks.