From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>, Kenichi Handa <handa@gnu.org>
Cc: juri@linkov.net, styang@fastmail.com, stephen.berman@gmx.net,
monnier@iro.umontreal.ca, 45379@debbugs.gnu.org
Subject: bug#45379: 28.0.50; Degraded Performance of describe-buffer-bindings
Date: Sat, 06 Mar 2021 10:15:16 +0200 [thread overview]
Message-ID: <83v9a4wve3.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkgYWQOzDP7WaYeyS5pS3ZA7iY4Fs-1F2Gymtata7A8nw@mail.gmail.com> (message from Stefan Kangas on Fri, 5 Mar 2021 20:44:33 -0800)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 5 Mar 2021 20:44:33 -0800
> Cc: Juri Linkov <juri@linkov.net>, martin rudalics <rudalics@gmx.at>, Eli Zaretskii <eliz@gnu.org>,
> 45379@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
> Stephen Berman <stephen.berman@gmx.net>
>
> It turns out that we were doing unnecessary looping due to the above
> mentioned commit. While working on this, I also found that we can get
> rid of an unnecessary call to char_table_ref_and_range, which should
> make this function run even faster.
I'm not sure I understand the reasons for each of the changes here.
char-tables are a tricky data structure, so I'd like to make sure this
change doesn't make our code subtly incorrect.
So could you please walk us through the proposed changes, adding
explanations for each part as you go?
(And what do char-tables have to do with describing key bindings,
btw?)
> I'm also copying in Kenichi Handa, who was the last to touch this code.
> Handa-san, please let us know if you have any comments on this patch.
> Thanks in advance.
AFAICT, you didn't CC Kenichi; I have now added him to the discussion.
Thanks.
next prev parent reply other threads:[~2021-03-06 8:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 6:01 bug#45379: 28.0.50; Degraded Performance of describe-buffer-bindings styang
2021-01-08 16:47 ` Sheng Yang
2021-01-08 17:00 ` Stefan Kangas
2021-01-08 17:08 ` Stefan Kangas
2021-02-04 15:43 ` Sheng Yang
2021-03-06 4:44 ` Stefan Kangas
2021-03-06 8:15 ` Eli Zaretskii [this message]
2021-03-07 1:42 ` handa
2021-03-07 6:15 ` Eli Zaretskii
2021-03-30 7:01 ` Eli Zaretskii
2021-04-01 15:06 ` handa
2021-04-14 3:06 ` Sheng Yang
2021-03-07 8:12 ` Stefan Kangas
2021-03-07 8:38 ` Eli Zaretskii
2021-05-04 23:31 ` Stefan Kangas
2021-05-06 10:11 ` Eli Zaretskii
2021-05-13 10:10 ` Eli Zaretskii
2021-06-26 21:51 ` Sheng Yang
2021-06-27 5:56 ` Eli Zaretskii
2021-09-07 18:53 ` Eli Zaretskii
2021-09-18 10:37 ` Eli Zaretskii
2021-09-18 12:34 ` Stefan Kangas
2021-09-18 13:24 ` Eli Zaretskii
2021-09-18 14:39 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v9a4wve3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=45379@debbugs.gnu.org \
--cc=handa@gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=stefan@marxist.se \
--cc=stephen.berman@gmx.net \
--cc=styang@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).