From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets Date: Sat, 13 Mar 2021 12:54:38 +0200 Message-ID: <83v99vias1.fsf@gnu.org> References: <83a6r9mwgk.fsf@gnu.org> <8335x1mpdk.fsf@gnu.org> <83h7lfjyv7.fsf@gnu.org> <837dmbjvpe.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33782"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alan@idiocy.org, 47074@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 13 11:55:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lL1vJ-0008f2-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Mar 2021 11:55:09 +0100 Original-Received: from localhost ([::1]:51556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lL1vI-0005lN-0J for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Mar 2021 05:55:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lL1vB-0005lF-T1 for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 05:55:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47599) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lL1vB-0005Pg-KX for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 05:55:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lL1vB-0005nG-JT for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 05:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Mar 2021 10:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47074 X-GNU-PR-Package: emacs Original-Received: via spool by 47074-submit@debbugs.gnu.org id=B47074.161563288422245 (code B ref 47074); Sat, 13 Mar 2021 10:55:01 +0000 Original-Received: (at 47074) by debbugs.gnu.org; 13 Mar 2021 10:54:44 +0000 Original-Received: from localhost ([127.0.0.1]:59145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lL1ut-0005mh-Ps for submit@debbugs.gnu.org; Sat, 13 Mar 2021 05:54:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lL1ur-0005mT-A7 for 47074@debbugs.gnu.org; Sat, 13 Mar 2021 05:54:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60594) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lL1ul-00059h-9c; Sat, 13 Mar 2021 05:54:35 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2698 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lL1uk-0001Us-LA; Sat, 13 Mar 2021 05:54:35 -0500 In-Reply-To: (message from Stefan Kangas on Sat, 13 Mar 2021 04:35:43 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202253 Archived-At: > From: Stefan Kangas > Date: Sat, 13 Mar 2021 04:35:43 -0600 > Cc: alan@idiocy.org, 47074@debbugs.gnu.org > > Eli Zaretskii writes: > > >> IIUC, it would show the :on and :off text on such configurations, > >> i.e. "[X]" and "[ ]". > > > > That'd be a regression, no? > > Are there any systems we care about where librsvg is not available? Do > we think it is important to support these graphical icons on those > systems? If the answer is yes to both of these questions, then I guess > we should count it as a regression. Since librsvg is an _optional_ dependency, IMO the answer is YES by definition, right? > > Can we arrange for the old XPM files to be used if SVG is not > > available? > > Perhaps fixing this it is as easy as moving/copying the old XPM files to > ui/.xpm, but I'd need to test it as I didn't study the code > very closely. Yes, I think copying the XPM file would be okay. Alternatively, we could move and rename the new SVG files. They are in a separate directory just because of the license? If so, I don't think that's a string enough reason to segregate them, we could just mention in the README in etc/images that these files (with an explicit list) are from so-and-so place under such-and-such license.