From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project Date: Sun, 21 Mar 2021 08:17:30 +0200 Message-ID: <83v99lav45.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35226"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47287@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 21 07:18:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNrPq-00093L-6w for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 07:18:22 +0100 Original-Received: from localhost ([::1]:47654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNrPp-0000wi-5W for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 02:18:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNrPW-0000v8-JN for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 02:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41909) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNrPV-0003wd-Mf for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 02:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNrPV-000310-Ik for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 02:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Mar 2021 06:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47287 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47287-submit@debbugs.gnu.org id=B47287.161630745611560 (code B ref 47287); Sun, 21 Mar 2021 06:18:01 +0000 Original-Received: (at 47287) by debbugs.gnu.org; 21 Mar 2021 06:17:36 +0000 Original-Received: from localhost ([127.0.0.1]:53455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNrP6-00030N-2z for submit@debbugs.gnu.org; Sun, 21 Mar 2021 02:17:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNrP4-00030A-61 for 47287@debbugs.gnu.org; Sun, 21 Mar 2021 02:17:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35998) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNrOy-0003gY-Q0; Sun, 21 Mar 2021 02:17:29 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3973 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lNrOy-0006hV-4E; Sun, 21 Mar 2021 02:17:28 -0400 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202757 Archived-At: > Date: Sun, 21 Mar 2021 00:28:24 +0100 > From: Theodor Thornhill via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This patch adds an interactive command 'project-remove-known-project', > that lets the user interactively remove a project from the project > list. My usecase is that sometimes when a directory is moved, the > project isn't deleted from the list. Thanks. I'll let Dmitry and others comment about the command itself, but a couple of minor nits, mainly regarding documentation: > ++++ > +*** New command 'project-remove-known-project'. > +This command lets you interactively remove an entry from the list of projects > +in 'project-list-file' > + The "+++" mark means that the manuals have been updated for this change, but the patch doesn't include any change for the manuals. If this command is accepted, I do think it should be mentioned in the user manual. > +(defun project-remove-known-project (dir) > + "Remove directory DIR, a known project from the project list. This sounds somewhat confusingly: is DIR a project or a directory? Can this be rephrased to avoid the confusion? > +Announce the projects removal from the `project-list-file'." ^^^^^^^^ "project's". And I'm not sure this part is needed in the doc string. And the message itself perhaps should be suppressed if the function is called non-interactively? > This command is modelled after the already present > 'project--remove-from-project-list', but that function isn't > interactive, and also has a specific purpose. So why doesn't your implementation call that function?