From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Wed, 05 May 2021 15:01:37 +0300 Message-ID: <83v97x2xum.fsf@gnu.org> References: <834kfmabvs.fsf@gnu.org> <83tunj651i.fsf@gnu.org> <83lf8u68bu.fsf@gnu.org> <83mtta4gtf.fsf@gnu.org> <83fsz24f2x.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38653"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48137@debbugs.gnu.org, monnier@iro.umontreal.ca To: Ioannis Kappas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 14:03:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leGFF-0009xE-BK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 14:03:13 +0200 Original-Received: from localhost ([::1]:60370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leGFE-00035E-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 08:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leGF4-000358-DZ for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 08:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48178) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leGF4-0006Zd-6L for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 08:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leGF4-0002XI-3G for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 08:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.16202161249738 (code B ref 48137); Wed, 05 May 2021 12:03:02 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 5 May 2021 12:02:04 +0000 Original-Received: from localhost ([127.0.0.1]:59720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leGE8-0002X0-Cp for submit@debbugs.gnu.org; Wed, 05 May 2021 08:02:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leGE4-0002Wb-1D for 48137@debbugs.gnu.org; Wed, 05 May 2021 08:02:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42688) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leGDy-0005wH-G6; Wed, 05 May 2021 08:01:54 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2342 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1leGDu-0005rV-Sp; Wed, 05 May 2021 08:01:51 -0400 In-Reply-To: (message from Ioannis Kappas on Wed, 5 May 2021 08:03:17 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205680 Archived-At: > From: Ioannis Kappas > Date: Wed, 5 May 2021 08:03:17 +0100 > Cc: Stefan Monnier , 48137@debbugs.gnu.org > > Currently, `package-install-file' reads the package contents into a > buffer and calls `package-install-from-buffer' to parse the headers, > download & install its dependencies, and finally install the package > itself from the buffer. > > Just to confirm, what we are discussing as a solution (at a high > level) is to parse the package headers from a decoded buffer, download > & install its dependencies, and copy/extract the package file to the > elpa user dir? My idea was to read the file literally, without decoding, then parse the package headers from that. Stefan seems to think it's non-trivial, which makes me suspect that I'm missing something.