From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33847: 27.0.50; emacsclient does not find server socket Date: Sat, 24 Jul 2021 11:25:37 +0300 Message-ID: <83v950yv7i.fsf@gnu.org> References: <8a6fc59c-08b3-e274-4fb1-74674c79540a@cs.ucla.edu> <27d2f2eb-8956-4088-f3ec-5ff6c2cf2e8f@cs.ucla.edu> <87eeo27v6k.fsf@gnus.org> <83lfi79klf.fsf@gnu.org> <831rjya5yy.fsf@gnu.org> <8333533f-08ec-acd4-2fbf-f06e78591e98@cs.ucla.edu> <83v9h99awv.fsf@gnu.org> <878s1yjy20.fsf@gnus.org> <83lf5y2t78.fsf@gnu.org> <878s1yi8jc.fsf@gnus.org> <83h7gm2r4j.fsf@gnu.org> <87wnphe06g.fsf@gnus.org> <87r1fpdzuy.fsf@gnus.org> <838s1w1b7x.fsf@gnu.org> <5f457b50-c1bd-4856-33c7-f85edf111bd0@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30833"; mail-complaints-to="usenet@ciao.gmane.io" Cc: teika@gmx.com, 33847@debbugs.gnu.org, larsi@gnus.org, ulm@gentoo.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 24 10:27:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7D00-0007r6-SY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jul 2021 10:27:08 +0200 Original-Received: from localhost ([::1]:59264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Czz-0006Jr-Ue for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jul 2021 04:27:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Czu-0006JU-7l for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 04:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7Czt-0004j2-MG for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 04:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7Czt-0003wY-I7 for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 04:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jul 2021 08:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33847 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33847-submit@debbugs.gnu.org id=B33847.162711516615093 (code B ref 33847); Sat, 24 Jul 2021 08:27:01 +0000 Original-Received: (at 33847) by debbugs.gnu.org; 24 Jul 2021 08:26:06 +0000 Original-Received: from localhost ([127.0.0.1]:45124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Cyw-0003v5-1L for submit@debbugs.gnu.org; Sat, 24 Jul 2021 04:26:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Cys-0003un-2O for 33847@debbugs.gnu.org; Sat, 24 Jul 2021 04:26:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34372) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Cyl-0003ds-HJ; Sat, 24 Jul 2021 04:25:51 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2294 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Cyl-0003Pz-54; Sat, 24 Jul 2021 04:25:51 -0400 In-Reply-To: <5f457b50-c1bd-4856-33c7-f85edf111bd0@cs.ucla.edu> (message from Paul Eggert on Sat, 24 Jul 2021 00:48:25 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210623 Archived-At: > Cc: larsi@gnus.org, teika@gmx.com, 33847@debbugs.gnu.org, ulm@gentoo.org > From: Paul Eggert > Date: Sat, 24 Jul 2021 00:48:25 -0700 > > On 7/23/21 11:23 PM, Eli Zaretskii wrote: > > > why in conjunction with this particular issue? > > It's typically better to sync to a single coherent version of Gnulib, > than to take bits and pieces from different versions of Gnulib. That way > one needn't worry about version mismatch. Yes, but making changes in most/all Gnulib while fixing a minor issue in a single auxiliary program is IMO too much, and stretches this principle way beyond any reasonable limit. So I'd prefer to make these Gnulib updates a separate changeset, if that's feasible. > >> Although I fixed the glitches Eli noted, the other Gnulib changes may > >> need further changes to Emacs's Microsoft-related code. > > > > Which of the Gnulib changes might need that, please? > > I said that more as boilerplate than as careful analysis. But in looking > at the patch more carefully, there may be issues in nt/gnulib-cfg.mk > where you have to set the following appropriately for MS-Windows: > > OMIT_GNULIB_MODULE_realloc-gnu > OMIT_GNULIB_MODULE_realloc-posix > > The realloc-posix module supplies a 'realloc' that conforms to POSIX > (i.e., it sets errno when it fails, and it refuses to allocate anything > larger than PTRDIFF_MAX in size). > > The realloc-gnu module in addition makes sure that 'realloc' is > compatible with GNU realloc (i.e., realloc (NULL, 0) returns nonnull > when it succeeds). > > The new file lib/realloc.c arranges for a replacement realloc on > platforms where realloc-posix and/or realloc-gnu discover that the > system realloc doesn't match glibc realloc in behavior. We cannot use these modules on MS-Windows because we have our private implementation of malloc/realloc/free in w32heap.c. Any problems with errno and return values for zero-sized allocations must be handled by our own code there (we could borrow the ideas from Gnulib, of course). > The msdos directory may need to do something similar. That's a different port of Emacs and a different libc, so the results are different. > There may be other issues, but these are the ones that jump out at me. Can you tell which Gnulib modules are affected by the new "--disable-year2038" option? This might have direct effect on how Emacs is built with mingw.org's MinGW (which is what I use), and in general to the entire issue of supporting old 32-bit versions of MS-Windows. > Hmm, come to think of it, does Emacs already arrange to avoid the > problematic realloc behavior areas? If so, we can avoid using > realloc-gnu and realloc-posix, which would simplify the patch a bit. How would Emacs arrange to avoid these problems? I could take a look if I knew what I should look for. Thanks.