unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: b.riefenstahl@turtle-trading.net
Cc: 49782@debbugs.gnu.org
Subject: bug#49782: 28.0.50; set-fontset-font crashes in init (server)
Date: Fri, 30 Jul 2021 23:12:09 +0300	[thread overview]
Message-ID: <83v94rpnmu.fsf@gnu.org> (raw)
In-Reply-To: <83wnp7po2q.fsf@gnu.org> (message from Eli Zaretskii on Fri, 30 Jul 2021 23:02:37 +0300)

> Date: Fri, 30 Jul 2021 23:02:37 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 49782@debbugs.gnu.org
> 
> > But that additional condition re-introduces the original problem.
> 
> Then I'll need a backtrace from a live Emacs process with "xbacktrace"
> results as well, and in a build without optimizations, so I could see
> what's the difference between these two use cases.

But before you embark on that adventure, please try another stab in
the dark:

diff --git a/src/fontset.c b/src/fontset.c
index d2d428d..7d4bd65 100644
--- a/src/fontset.c
+++ b/src/fontset.c
@@ -1356,15 +1356,16 @@ check_fontset_name (Lisp_Object name, Lisp_Object *frame)
   int id;
   struct frame *f = decode_live_frame (*frame);
 
-  if (!FRAME_WINDOW_P (f) && !FRAME_INITIAL_P (f))
-    error ("Can't use fontsets in non-GUI frames");
-
   XSETFRAME (*frame, f);
 
   if (EQ (name, Qt))
     return Vdefault_fontset;
   if (NILP (name))
-    id = FRAME_FONTSET (f);
+    {
+      if (!FRAME_WINDOW_P (f))
+	error ("Can't use fontsets in non-GUI frames");
+      id = FRAME_FONTSET (f);
+    }
   else
     {
       CHECK_STRING (name);





  reply	other threads:[~2021-07-30 20:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 12:54 bug#49782: 28.0.50; set-fontset-font crashes in init (server) Benjamin Riefenstahl
2021-07-30 14:05 ` Benjamin Riefenstahl
2021-07-30 14:10 ` Eli Zaretskii
2021-07-30 17:50   ` Benjamin Riefenstahl
2021-07-30 18:19     ` Eli Zaretskii
2021-07-30 18:35   ` Benjamin Riefenstahl
2021-07-30 18:52     ` Eli Zaretskii
2021-07-30 19:26       ` Benjamin Riefenstahl
2021-07-30 20:02         ` Eli Zaretskii
2021-07-30 20:12           ` Eli Zaretskii [this message]
2021-07-31  6:29             ` Eli Zaretskii
2021-07-31 13:05           ` Benjamin Riefenstahl
2021-07-31 13:23             ` Eli Zaretskii
2021-07-30 20:07     ` Lars Ingebrigtsen
2021-07-30 20:09       ` Lars Ingebrigtsen
2021-07-31 12:57       ` Benjamin Riefenstahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v94rpnmu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=49782@debbugs.gnu.org \
    --cc=b.riefenstahl@turtle-trading.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).