From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41343: tab-bar-mode: Close tab on mouse-2 click Date: Wed, 11 Aug 2021 14:56:26 +0300 Message-ID: <83v94cdwk5.fsf@gnu.org> References: <87wnp2cg52.fsf@linkov.net> <83tuk5la2u.fsf@gnu.org> <877dh18lj3.fsf@mail.linkov.net> <83y29gjvjh.fsf@gnu.org> <8735rn8jz6.fsf@mail.linkov.net> <83sfznhywm.fsf@gnu.org> <87tuk356ia.fsf@mail.linkov.net> <83im0iiw8n.fsf@gnu.org> <877dgvkt1z.fsf@mail.linkov.net> <83wnotfpak.fsf@gnu.org> <87k0ksecbq.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25589"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41343@debbugs.gnu.org, stefankangas@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 11 13:57:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDmr6-0006QD-W0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Aug 2021 13:57:08 +0200 Original-Received: from localhost ([::1]:41108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDmr6-0003e2-1M for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Aug 2021 07:57:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDmr0-0003de-8L for bug-gnu-emacs@gnu.org; Wed, 11 Aug 2021 07:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50377) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDmr0-0004L4-1P for bug-gnu-emacs@gnu.org; Wed, 11 Aug 2021 07:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mDmqz-0008Hf-Vk for bug-gnu-emacs@gnu.org; Wed, 11 Aug 2021 07:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Aug 2021 11:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41343-submit@debbugs.gnu.org id=B41343.162868298431796 (code B ref 41343); Wed, 11 Aug 2021 11:57:01 +0000 Original-Received: (at 41343) by debbugs.gnu.org; 11 Aug 2021 11:56:24 +0000 Original-Received: from localhost ([127.0.0.1]:33690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDmqO-0008Gl-EK for submit@debbugs.gnu.org; Wed, 11 Aug 2021 07:56:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDmqM-0008GV-Th for 41343@debbugs.gnu.org; Wed, 11 Aug 2021 07:56:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55768) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDmqG-0003rm-Eg; Wed, 11 Aug 2021 07:56:16 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3838 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDmqE-0002SB-Vi; Wed, 11 Aug 2021 07:56:16 -0400 In-Reply-To: <87k0ksecbq.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 11 Aug 2021 10:01:53 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211575 Archived-At: > From: Juri Linkov > Cc: stefankangas@gmail.com, 41343@debbugs.gnu.org > Date: Wed, 11 Aug 2021 10:01:53 +0300 > > >> So now I've completely redesigned the event processing on the tab bar. > > > > Thanks, this looks much, much better to me. > > Could you please help to check if everything is correct > on the Windows part (unfortunately, I don't have Windows). > The changes in w32inevt.c and w32term.c just mirror the changes > in xdisp.c and xterm.c, but I'm sure I might have made a typo. I will, if you tell me what to try after applying the patch. > There is the need to apply an additional patch below, > because the tab symbol is carried by the event in its > OBJECT slot, but some functions expect that the OBJECT > slot should contain only (STRING . STRING-POS) That expectation is according to the documented behavior, so it is correct. I don't quite understand why you need to break the contract here. Can you elaborate where do the deviant values come and why they must have a different value form?