From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33414: 27.0.50; inhibit-changing-match-data can be t in syntax-propertize functions, breaking backtrace and looking-at Date: Sun, 05 Sep 2021 12:40:25 +0300 Message-ID: <83v93ftl6e.fsf@gnu.org> References: <83lg5ru88i.fsf@gnu.org> <83k1lbu5xj.fsf@gnu.org> <87r1eylsea.fsf@gnus.org> <22C40A08-9611-4925-B840-8F3795175B0F@gmail.com> <87eea3nzel.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33797"; mail-complaints-to="usenet@ciao.gmane.io" Cc: p.stephani2@gmail.com, pipcet@gmail.com, 33414@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 05 11:41:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMoeF-0008e2-Qz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Sep 2021 11:41:11 +0200 Original-Received: from localhost ([::1]:39530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMoeD-0006BB-U2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Sep 2021 05:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMoe6-00068N-Q4 for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 05:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37698) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMoe6-0001ut-Fv for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 05:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mMoe6-0003am-Bk for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 05:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Sep 2021 09:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33414 X-GNU-PR-Package: emacs Original-Received: via spool by 33414-submit@debbugs.gnu.org id=B33414.163083483113763 (code B ref 33414); Sun, 05 Sep 2021 09:41:02 +0000 Original-Received: (at 33414) by debbugs.gnu.org; 5 Sep 2021 09:40:31 +0000 Original-Received: from localhost ([127.0.0.1]:49244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mModb-0003Zv-Ci for submit@debbugs.gnu.org; Sun, 05 Sep 2021 05:40:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mModZ-0003Zh-Ld for 33414@debbugs.gnu.org; Sun, 05 Sep 2021 05:40:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59002) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mModT-0001Ix-Uh; Sun, 05 Sep 2021 05:40:24 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1585 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mModR-0007bD-Iu; Sun, 05 Sep 2021 05:40:23 -0400 In-Reply-To: <87eea3nzel.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 05 Sep 2021 11:29:38 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213483 Archived-At: > From: Lars Ingebrigtsen > Cc: Eli Zaretskii , Pip Cet , > 33414@debbugs.gnu.org > Date: Sun, 05 Sep 2021 11:29:38 +0200 > > Philipp writes: > > >> `inhibit-changing-match-data' just seems like a bad interface to me. > > > > Yes, using a public dynamic variable (i.e., public global mutable > > state) to influence the behavior of a function is normally a bad idea. FWIW, I don't share the above view. We bind variables to affect behavior of functions all over the place, and that is perfectly okay, IMO. > -@defun looking-at regexp > +@defun looking-at regexp &optional inhibit-save ^^^^^^^^^^^^ A typo? > --- a/lisp/auth-source.el > +++ b/lisp/auth-source.el > @@ -1447,12 +1447,13 @@ auth-source-netrc-saver > `auth-source-netrc-cache' to avoid prompting more than once." > (let* ((key (format "%s %s" file (rfc2104-hash 'md5 64 16 file add))) > (cached (assoc key auth-source-netrc-cache))) > - > + (message "hello 2 %s" cached) > (if cached > (auth-source-do-trivia > "auth-source-netrc-saver: found previous run for key %s, returning" > key) > (with-temp-buffer > + (message "hello 3 %s" file) > (when (file-exists-p file) > (insert-file-contents file)) > (when auth-source-gpg-encrypt-to > @@ -1472,8 +1473,11 @@ auth-source-netrc-saver > (done (not (eq auth-source-save-behavior 'ask))) > (bufname "*auth-source Help*") > k) > + (message "hello 3 %s %s" auth-source-save-behavior done) > (while (not done) > + (message "hello 3.5") > (setq k (auth-source-read-char-choice prompt '(?y ?n ?N ?e ??))) > + (message "hello 4 %s" k) > (cl-case k > (?y (setq done t)) > (?? (save-excursion Debugging code left-overs? > +(make-obsolete-variable 'inhibit-changing-match-data nil "28.1") Really? why obsolete it?