From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50660: 28.0.50; Text artifacting when the cursor moves over text under mouse face that originally displayed a box Date: Mon, 27 Sep 2021 14:52:54 +0300 Message-ID: <83v92mkzft.fsf@gnu.org> References: <87czp6ysw7.fsf.ref@yahoo.com> <87y27uro4c.fsf@gnus.org> <877dfdz9ni.fsf@yahoo.com> <831r5l5d6d.fsf@gnu.org> <87h7egy8jo.fsf@yahoo.com> <838rzs4i09.fsf@gnu.org> <87fsu06oxi.fsf@yahoo.com> <83ee9j3ju3.fsf@gnu.org> <834kaf3ets.fsf@gnu.org> <8335pz3dli.fsf@gnu.org> <87r1dj4q4m.fsf@yahoo.com> <83zgs71su7.fsf@gnu.org> <87k0jb4k5l.fsf@yahoo.com> <83sfxz1pw0.fsf@gnu.org> <87o88m14g0.fsf@yahoo.com> <83sfxyxeer.fsf@gnu.org> <87h7ee1252.fsf@yahoo.com> <83pmt2xcox.fsf@gnu.org> <87lf3myhlb.fsf@yahoo.com> <87a6jzvnpq.fsf@yahoo.com> <83o88fom1k.fsf@gnu.org> <871r5bvex8.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13071"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 50660@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 27 13:53:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUpC6-0003DE-GN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Sep 2021 13:53:14 +0200 Original-Received: from localhost ([::1]:33010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUpC5-0002WM-EU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Sep 2021 07:53:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUpBu-0002Vy-LH for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2021 07:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56601) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUpBu-0006bU-Bp for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2021 07:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUpBu-0006WW-0g for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2021 07:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Sep 2021 11:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50660 X-GNU-PR-Package: emacs Original-Received: via spool by 50660-submit@debbugs.gnu.org id=B50660.163274357825061 (code B ref 50660); Mon, 27 Sep 2021 11:53:01 +0000 Original-Received: (at 50660) by debbugs.gnu.org; 27 Sep 2021 11:52:58 +0000 Original-Received: from localhost ([127.0.0.1]:39914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUpBp-0006W7-FY for submit@debbugs.gnu.org; Mon, 27 Sep 2021 07:52:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUpBn-0006Vn-G5 for 50660@debbugs.gnu.org; Mon, 27 Sep 2021 07:52:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51958) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUpBi-0006Qr-3q; Mon, 27 Sep 2021 07:52:50 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3031 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUpBh-0004uS-NV; Mon, 27 Sep 2021 07:52:50 -0400 In-Reply-To: <871r5bvex8.fsf@yahoo.com> (message from Po Lu on Sun, 26 Sep 2021 17:56:03 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215652 Archived-At: > From: Po Lu > Cc: larsi@gnus.org, 50660@debbugs.gnu.org > Date: Sun, 26 Sep 2021 17:56:03 +0800 > > > First, which call to display_and_set_cursor are we talking about? > > The call inside show_mouse_face. > > > And what do you mean by "erase_phys_cursor gets very confused" -- > > confused how? > > It calls draw_phys_cursor_glyph, which draws the glyph at the original X > position, and not the position with the mouse face offset applied. > > What I was asking is whether or not it's okay to not restore > phys_cursor->x to its original value after the call to > display_and_set_cursor inside show_mouse_face, or if I should also > calculate and add the offset in erase_phys_cursor (if > cursor_in_mouse_face_p) instead. I think I'm still a bit confused. Can you show the patch you have where you see these problems with erase_phys_cursor? P.S. And sorry for the delay in answering.