From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50852: [PATCH] Fix search of the look program. Date: Tue, 28 Sep 2021 10:15:06 +0300 Message-ID: <83v92ljhmt.fsf@gnu.org> References: <87wnn17t85.fsf@gmail.com> <8335ppkzc1.fsf@gnu.org> <87ilylfcvt.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36925"; mail-complaints-to="usenet@ciao.gmane.io" Cc: andremegafone@gmail.com, 50852@debbugs.gnu.org, stefan@marxist.se To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 28 09:18:00 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mV7NI-0009Ok-6v for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Sep 2021 09:18:00 +0200 Original-Received: from localhost ([::1]:34684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mV7NH-0007Jd-0m for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Sep 2021 03:17:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mV7LO-0005CP-Hx for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 03:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mV7LO-0007KM-9e for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 03:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mV7LO-0001QI-6D for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 03:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Sep 2021 07:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 50852-submit@debbugs.gnu.org id=B50852.16328133085398 (code B ref 50852); Tue, 28 Sep 2021 07:16:02 +0000 Original-Received: (at 50852) by debbugs.gnu.org; 28 Sep 2021 07:15:08 +0000 Original-Received: from localhost ([127.0.0.1]:43617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV7KW-0001P0-EU for submit@debbugs.gnu.org; Tue, 28 Sep 2021 03:15:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV7KU-0001OK-PM for 50852@debbugs.gnu.org; Tue, 28 Sep 2021 03:15:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59828) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mV7KP-0006Qg-C1; Tue, 28 Sep 2021 03:15:01 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3051 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mV7KO-0000pv-TY; Tue, 28 Sep 2021 03:15:01 -0400 In-Reply-To: <87ilylfcvt.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 28 Sep 2021 08:11:18 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215750 Archived-At: > From: Lars Ingebrigtsen > Cc: Stefan Kangas , andremegafone@gmail.com, > 50852@debbugs.gnu.org > Date: Tue, 28 Sep 2021 08:11:18 +0200 > > Eli Zaretskii writes: > > > In this case, why not simply have the value as "look" with no leading > > directories? If the program is installed, it will be found when it's > > invoked, and if it isn't installed, the user gets an error message at > > that time. > > That's a good point. And the ispell-look-p variable is itself rather > odd -- why have both ispell-look-command and that variable (with a > non-standard name)? Right. The existence of "look" should IMO be tested as part of ispell-lookup-words, not when the package loads. Then the command could decide whether to use "look" or Grep at that time, and the need for the ispell-look-p variable would disappear.