From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52378: 28.0.50; [PATCH] Reinstate a guard on compute_window_start() Date: Thu, 09 Dec 2021 09:22:33 +0200 Message-ID: <83v8zyuts6.fsf@gnu.org> References: <87tufibxzg.fsf@dick> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4233"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52378-done@debbugs.gnu.org To: dick.r.chiang@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 09 08:23:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvDmG-0000v3-Rs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Dec 2021 08:23:41 +0100 Original-Received: from localhost ([::1]:52086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvDmF-0004iD-MK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Dec 2021 02:23:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvDlp-0004bY-MW for bug-gnu-emacs@gnu.org; Thu, 09 Dec 2021 02:23:14 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mvDle-0007go-3d for bug-gnu-emacs@gnu.org; Thu, 09 Dec 2021 02:23:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mvDle-0005iL-09 for bug-gnu-emacs@gnu.org; Thu, 09 Dec 2021 02:23:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Dec 2021 07:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 52378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 52378@debbugs.gnu.org, eliz@gnu.org, dick.r.chiang@gmail.com Original-Received: via spool by 52378-done@debbugs.gnu.org id=D52378.163903458021937 (code D ref 52378); Thu, 09 Dec 2021 07:23:01 +0000 Original-Received: (at 52378-done) by debbugs.gnu.org; 9 Dec 2021 07:23:00 +0000 Original-Received: from localhost ([127.0.0.1]:42276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvDlb-0005hl-Nr for submit@debbugs.gnu.org; Thu, 09 Dec 2021 02:22:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvDlZ-0005hX-Bd for 52378-done@debbugs.gnu.org; Thu, 09 Dec 2021 02:22:57 -0500 Original-Received: from [2001:470:142:3::e] (port=32838 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvDlS-0007fh-Sx; Thu, 09 Dec 2021 02:22:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=v540T9O17HY2yFC1Fc8eH5/NSOSYhnIuIz4Hx0+v9nU=; b=NOBQ+aZJ2SGv QQIJLvnhzZ3O6TkovF7do2C7YNmpEH+d3SuXFBYOWy2WfredRM0Y9Rp7hwvmyqBYPpAtdJz3cEzkS 5U8FCTATKbFK5eiOkZ0ly82HcAMcAx3lLjg8LfcbNWR8Fp5FpEWK8Z4gOKJluTXvpL+yKfeLOpbMg b00n3TFmDKuprFFEaB1GdxSEVo4leZowx1WwGnGJx0ClzENkQjm7NkS7aix/sfKvY2kSMrafHLb8h +6u41Ushc09rZ9oZItAUaPddf6ozenWR5MswwpYtU4ZF8JExmH2Ryct7Tf0xm0OtL2hqn+194eYCn mSUX0P7dLyVGBoBphYmBhQ==; Original-Received: from [87.69.77.57] (port=1081 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvDlR-000518-UE; Thu, 09 Dec 2021 02:22:50 -0500 In-Reply-To: <87tufibxzg.fsf@dick> (dick.r.chiang@gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221979 Archived-At: > From: dick.r.chiang@gmail.com > Date: Wed, 08 Dec 2021 16:14:27 -0500 > > >From c0d3b2f75cd1ef0d4b45442ab073d8cd0a448a08 Mon Sep 17 00:00:00 2001 > From: dickmao > Date: Wed, 8 Dec 2021 16:11:34 -0500 > Subject: [PATCH] A common error > > * src/xdisp.c (compute_window_start_on_continuation_line): > Align code with comment. The current code is correct. It's the comment that might confuse: it describes the conditions under which we do NOT want to execute the code in the following block (that's what "give up" means in this case). So "||" is correct, and you need to reverse the conditions to understand what the comment says. For example, it says "too far", but the condition says "less than", not "greater than". I tried to clarify the comment on the release branch.