From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53322: 28.0.91; "C-h c" errors out for menu-bar clicks Date: Mon, 17 Jan 2022 20:48:35 +0200 Message-ID: <83v8yiurjw.fsf@gnu.org> References: <83y23eutnq.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39757"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53322@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 17 19:50:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9X5S-000ADT-3J for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jan 2022 19:50:38 +0100 Original-Received: from localhost ([::1]:50524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9X5Q-0006FJ-RG for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jan 2022 13:50:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9X3v-0006D4-84 for bug-gnu-emacs@gnu.org; Mon, 17 Jan 2022 13:49:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9X3u-0005wy-T4 for bug-gnu-emacs@gnu.org; Mon, 17 Jan 2022 13:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9X3u-0004hQ-3i for bug-gnu-emacs@gnu.org; Mon, 17 Jan 2022 13:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jan 2022 18:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53322 X-GNU-PR-Package: emacs Original-Received: via spool by 53322-submit@debbugs.gnu.org id=B53322.164244533718050 (code B ref 53322); Mon, 17 Jan 2022 18:49:02 +0000 Original-Received: (at 53322) by debbugs.gnu.org; 17 Jan 2022 18:48:57 +0000 Original-Received: from localhost ([127.0.0.1]:47971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9X3o-0004h4-V8 for submit@debbugs.gnu.org; Mon, 17 Jan 2022 13:48:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9X3k-0004gl-EQ for 53322@debbugs.gnu.org; Mon, 17 Jan 2022 13:48:55 -0500 Original-Received: from [2001:470:142:3::e] (port=46014 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9X3e-0005ux-91; Mon, 17 Jan 2022 13:48:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8y2l/4RHk3L4d679rCkbX/oKOqzUVgwcs8HFulpP2AM=; b=h2viqoC1iWV2 nfqck8O7owN567gQrzTAdNOLcm+K1MlgWOv/KfWQZcKEmqH2Kud3iIprqD5dorW1i2JDnc8ugGwUa n+SwxNFoL2eTwdkEahjWSEwwAFk0FFUzky0TXBWvRnjW37oIJl578pXG5nKH9lHiD0+boQTOO0x73 qVY/kMLeeuuHBJMN2iBR/jhN8U9U7YZSHWGzerQPaIHqAzj7A9dLHtZLwYn4r7NZJsAMH33SijZwz cWZ/cSLBTWvdpj/DgO/CLfOc2B6JkJUUnIn9FLxSjGOOecfv1S+3W1tlKaYiHBEcU3NEJN+KF4iYs lpDMsPmBowr/DxzmlJSJUg==; Original-Received: from [87.69.77.57] (port=4733 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9X3d-0008Sc-HX; Mon, 17 Jan 2022 13:48:46 -0500 In-Reply-To: <83y23eutnq.fsf@gnu.org> (message from Eli Zaretskii on Mon, 17 Jan 2022 20:03:05 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224473 Archived-At: > Date: Mon, 17 Jan 2022 20:03:05 +0200 > From: Eli Zaretskii > > > C-h c > Click File->Open File from the menu bar > > This signals an error: > > posn-set-point: Position not in text area of window > > Same thing happens with "C-h k". Juri, this is a direct consequence of your changes in commit 8230a47: commit 8230a47ecc8c11f518ee20a9055c0c27339a6730 Author: Juri Linkov AuthorDate: Wed Dec 1 19:36:00 2021 +0200 Commit: Juri Linkov CommitDate: Wed Dec 1 19:36:00 2021 +0200 * lisp/help.el (help--analyze-key): Prefer posn-set-point over mouse-set-point * lisp/help.el (help--analyze-key): Use posn-set-point instead of mouse-set-point that runs the hook mouse-leave-buffer-hook via mouse-minibuffer-check. Using posn-set-point also unnecessitates extra conditions added in bug#51421. The sad part is that the "unnecessary extra conditions" added in bug#51421 fixed the very problem that your change now reintroduced. Did you test that change with the original recipe which was solved in bug#51421? Did it work for you back then? Any suggestions for how to fix this regression, except by reverting the above commit?