From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54296: Add buffer-matching functionality Date: Mon, 14 Mar 2022 15:00:20 +0200 Message-ID: <83v8wgk7tn.fsf@gnu.org> References: <87ee3d4cli.fsf@posteo.net> <87k0d35c82.fsf@gnus.org> <877d92unqn.fsf@posteo.net> <83bkyednvx.fsf@gnu.org> <87cziudmyg.fsf@posteo.net> <838rtheogd.fsf@gnu.org> <87ilskbgul.fsf@posteo.net> <83ilskcp9i.fsf@gnu.org> <87v8whio1a.fsf@posteo.net> <83czipkylw.fsf@gnu.org> <87pmmp9c63.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31456"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54296@debbugs.gnu.org, larsi@gnus.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 14 14:07:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTkQV-0007zC-If for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Mar 2022 14:07:55 +0100 Original-Received: from localhost ([::1]:42462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTkQU-0008Aa-E1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Mar 2022 09:07:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTkJr-0004ht-Ll for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2022 09:01:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTkJq-00039R-19 for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2022 09:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nTkJp-0000Aj-Vd for bug-gnu-emacs@gnu.org; Mon, 14 Mar 2022 09:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Mar 2022 13:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54296-submit@debbugs.gnu.org id=B54296.1647262841610 (code B ref 54296); Mon, 14 Mar 2022 13:01:01 +0000 Original-Received: (at 54296) by debbugs.gnu.org; 14 Mar 2022 13:00:41 +0000 Original-Received: from localhost ([127.0.0.1]:44332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTkJV-00009m-BP for submit@debbugs.gnu.org; Mon, 14 Mar 2022 09:00:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTkJT-00009Y-O0 for 54296@debbugs.gnu.org; Mon, 14 Mar 2022 09:00:40 -0400 Original-Received: from [2001:470:142:3::e] (port=46998 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTkJO-00036E-9T; Mon, 14 Mar 2022 09:00:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fQaKSOuH7ug+1IkEN0xSaunHs/FlEnzTF5C9DFF905U=; b=R/9BMgJZ8PgI I4YTYq72ZnOPWYvuNED4xGubz9ixET4gTwWPbBkSrJhsZkp14QdA31BWJysArqFmsf2GOKtsGR/Vr QsWx4nuglcTsmhGJUa7xKjkeA8FiUTZxMq9O5VfukdMEIFvOj0BCmlEuR8onmHghLuvuliblX8yts gfrb6uvLtYiraHOXsl7ULa05eu5EXN/S0kBxJX7zKGMz6g2L9RNGn6HV4OSkg65vAHyJCk772rz/S VfezYM9bvr+qAuM8lC8FQ6KvO9IytWGXou6tgpdVeyI/eYf4GkTE8R6j4gXFpAdBXtovAUNeQ27qG we59yITGNtf5dvgKcxjcIA==; Original-Received: from [87.69.77.57] (port=4770 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTkJN-0004Er-Md; Mon, 14 Mar 2022 09:00:34 -0400 In-Reply-To: <87pmmp9c63.fsf@posteo.net> (message from Philip Kaludercic on Mon, 14 Mar 2022 08:21:56 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228354 Archived-At: > From: Philip Kaludercic > Cc: larsi@gnus.org, 54296@debbugs.gnu.org > Date: Mon, 14 Mar 2022 08:21:56 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Cc: larsi@gnus.org, 54296@debbugs.gnu.org > >> Date: Sun, 13 Mar 2022 20:40:49 +0000 > >> > >> Eli Zaretskii writes: > >> > >> >> From: Philip Kaludercic > >> >> Cc: larsi@gnus.org, 54296@debbugs.gnu.org > >> >> Date: Fri, 11 Mar 2022 16:21:06 +0000 > >> >> > >> >> > I think we want in general avoid comparison with major-mode, and > >> >> > prefer derived-mode instead, and if so, IMO we had better did as we > >> >> > say and not exposed comparison to major mode unless we absolutely > >> >> > must. > >> >> > >> >> Would it be enough to clarify this point in the documentation string? > >> > > >> > What would you like to clarify? > >> > >> To clarify that the usage of (major-mode . foo-mode) might not be what > >> the user intends, and that in most cases derived-mode is preferable. > > > > I suggested to "clarify" that by not providing the 'major-mode' > > predicate at all. I still don't think I understand why it is so > > important that we should provide a special case for it. > > It is not inherently important, it is just that if the predicate would > also be used in project.el, then compatibility would have to be broken, > as the distinction between `major-mode' and `derived-mode' exists there. Then project.el could use the predicate route, right? It's quite a special case, AFAIU, so having a special solution is OK.