From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55676: [PATCH] non-recursive Lisp reader Date: Fri, 27 May 2022 19:01:54 +0300 Message-ID: <83v8trm0b1.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26903"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55676@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 27 18:34:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nucuw-0006oQ-BC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 May 2022 18:34:26 +0200 Original-Received: from localhost ([::1]:44126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nucuv-0001gM-1d for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 May 2022 12:34:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nucQY-0001NJ-Q3 for bug-gnu-emacs@gnu.org; Fri, 27 May 2022 12:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nucQY-00071u-Ge for bug-gnu-emacs@gnu.org; Fri, 27 May 2022 12:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nucQY-0007AB-De for bug-gnu-emacs@gnu.org; Fri, 27 May 2022 12:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 May 2022 16:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55676-submit@debbugs.gnu.org id=B55676.165366733127474 (code B ref 55676); Fri, 27 May 2022 16:03:02 +0000 Original-Received: (at 55676) by debbugs.gnu.org; 27 May 2022 16:02:11 +0000 Original-Received: from localhost ([127.0.0.1]:35657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nucPj-000794-I8 for submit@debbugs.gnu.org; Fri, 27 May 2022 12:02:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nucPe-00078X-It for 55676@debbugs.gnu.org; Fri, 27 May 2022 12:02:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nucPY-0006xz-BJ; Fri, 27 May 2022 12:02:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=As+CbJdX9MRH1oqkL9somfeHvxL1wcgTd6urJD4pf9A=; b=hUaPA32WipXlM9J48pVB 12V38wkDH7wD1GVNb9/DW8Hq0k4UejuUDwCfnlGBvZLPXwneiOYoguDXEljgOrZc+dmuaeNNs7Nqc klsopCo7O9qWG9mMzw8haVjzHHLxcVv595+yjM1oJZytBPt7BdH3jgqC1hw4g0wz7/JOBoU6zD8Y1 SLmAO5WEx8ommkQGuRYofVBplxJgndF3Zn+q7x4+AO7iEOmuZgBsw2QmUZki1oTNRUBl8yP4se2N6 NUjFSuuR4dtJzUOVe2cnnj5Fxeunu22EmZWMXUkHlW93Lxs9Oly6l1hZVGknpgrTPIvStGpm+ZOCe 6TjV4HZd7Psi/A==; Original-Received: from [87.69.77.57] (port=1109 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nucPX-00006q-7H; Fri, 27 May 2022 12:02:00 -0400 In-Reply-To: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 27 May 2022 15:33:35 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233215 Archived-At: > From: Mattias Engdegård > Date: Fri, 27 May 2022 15:33:35 +0200 > > You probably saw this one coming. It's a restructuring of the Lisp reader so that it no longer uses recursion for reading nested data structures. > > The primary motivation is eliminating the limitation of the C stack (and potential overflow crash). As a happy side-effect, the change improves reader performance by a few percent, exact amount depending on what is being read. This translates into a small but measurable speed-up in loading packages (.el and .elc), and in byte-compilation. The performance increase is both from removal of recursion and closer attention to performance. Thanks. One minor nit: you seem to have customized indentation in C source files in a way that is different from our conventions. Please reformat using our defaults (which use a mix of TABs and SPACEs).