From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57072: [BUG] update-glyphless-char-display and variation selectors Date: Tue, 16 Aug 2022 19:27:08 +0300 Message-ID: <83v8qsduhv.fsf@gnu.org> References: <83edxpvec4.fsf@gnu.org> <83leruq3p3.fsf@gnu.org> <83a68apxbm.fsf@gnu.org> <83pmh6nh2f.fsf@gnu.org> <83h72indie.fsf@gnu.org> <83edxloiu3.fsf@gnu.org> <83a689ochp.fsf@gnu.org> <878rnoaa13.fsf@gmail.com> <83fshwfid7.fsf@gnu.org> <87r11g8gj6.fsf@gmail.com> <87mtc48ct4.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57072@debbugs.gnu.org, svenssonaxel@gmail.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 16 18:29:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNzRX-0002oy-Lh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Aug 2022 18:29:27 +0200 Original-Received: from localhost ([::1]:50186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNzRW-0002jn-LZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Aug 2022 12:29:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNzQA-0000Rc-5F for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 12:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNzQ9-0000Uw-QJ for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 12:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNzQ9-0000Gw-Lz for bug-gnu-emacs@gnu.org; Tue, 16 Aug 2022 12:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Aug 2022 16:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57072 X-GNU-PR-Package: emacs Original-Received: via spool by 57072-submit@debbugs.gnu.org id=B57072.16606672481001 (code B ref 57072); Tue, 16 Aug 2022 16:28:01 +0000 Original-Received: (at 57072) by debbugs.gnu.org; 16 Aug 2022 16:27:28 +0000 Original-Received: from localhost ([127.0.0.1]:48124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNzPb-0000G5-MD for submit@debbugs.gnu.org; Tue, 16 Aug 2022 12:27:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNzPa-0000Ft-J4 for 57072@debbugs.gnu.org; Tue, 16 Aug 2022 12:27:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNzPU-0000Qd-KH; Tue, 16 Aug 2022 12:27:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Nl+9kllhVjkpiM1VHrUJtYwj09WwS8OVIPvHJg6L9YE=; b=edqEku8B0szg yfjNEg5qQk5cv1ofUSK9XiGY7hXYLIjp3tel0tiemx6AoZVFU19F7/Ve4yQF/J/ztjMhofF5daBru YAA/m3AISE8bcG8uYd3dvP2Gpo6vwOFkkZgyL+EsQeo2mFYTcwqlWKc5abhn794GZJjilPFlHT+Mi tXhO7BSZMap9/wE90s4DBi9GHViO6RkIHEe//niIwaiBv+G6UNqhMht7z3BpY1j/VIRlgTGLCNxHZ Du44QltJv5WEr5c/aUiL8arwdXc6SpksAKm9hRHerCpkyJZKiwjSVGkVkxuGtClmLnIcFAYDXaX3p NWa5UVFazsxPLZkQC4Z+LA==; Original-Received: from [87.69.77.57] (port=1679 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNzPT-0001UU-4Y; Tue, 16 Aug 2022 12:27:19 -0400 In-Reply-To: <87mtc48ct4.fsf@gmail.com> (message from Robert Pluim on Tue, 16 Aug 2022 16:48:07 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239972 Archived-At: > From: Robert Pluim > Cc: Eli Zaretskii , 57072@debbugs.gnu.org > Date: Tue, 16 Aug 2022 16:48:07 +0200 > > --- a/admin/unidata/blocks.awk > +++ b/admin/unidata/blocks.awk > @@ -224,9 +224,11 @@ FILENAME ~ "emoji-data.txt" && /^[0-9A-F].*; Emoji_Presentation / { > > END { > idx = 0 > - # ## These are here so that font_range can choose Emoji presentation > - # ## for the preceding codepoint when it encounters a VS > - override_start[idx] = "FE00" > + ## This is here so that font_range can choose Emoji presentation > + ## for the preceding codepoint when it encounters a VS-16 (U+FE0F). > + ## It originally covered the whole FE00-FE0F range, but that > + ## turned out to be a mistake. > + override_start[idx] = "FE0F" > override_end[idx] = "FE0F" > > for (k in override_start) > That LGTM, thanks. But please mention in the comment the stuff in composite.el which handles the other variation selectors, so that these different places would be easier to find and inspect.