From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59628: 29.0.50; treesit-beginning/end-of-defun problems in C/C++ Date: Sun, 27 Nov 2022 12:12:57 +0200 Message-ID: <83v8n0puxi.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24902"; mail-complaints-to="usenet@ciao.gmane.io" To: 59628@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 27 11:13:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozEf8-0006Ec-DF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Nov 2022 11:13:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozEeo-0006jf-B1; Sun, 27 Nov 2022 05:13:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozEem-0006jW-IV for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 05:13:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozEem-0007Sf-76 for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 05:13:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozEek-0000RT-00 for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 05:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Nov 2022 10:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59628 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16695439571688 (code B ref -1); Sun, 27 Nov 2022 10:13:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Nov 2022 10:12:37 +0000 Original-Received: from localhost ([127.0.0.1]:42123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozEeK-0000RA-V0 for submit@debbugs.gnu.org; Sun, 27 Nov 2022 05:12:37 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:39898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozEeG-0000R4-OV for submit@debbugs.gnu.org; Sun, 27 Nov 2022 05:12:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozEeG-0006iN-7B for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 05:12:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozEeE-0007S8-Li for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 05:12:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=vR22/pRST1sh/F0AZyI8E2N7BdupC7Q06S2HRqrOHSU=; b=DPQJtlh60M5Jug +usFCp2vB+Q7E6f/zBTdioy0cBr7hciWTEnjWCJpAbzbPN93e2ODeiTpwKCEtZVWlj/8atpKpFtvO 9Hhtwt+8Di5fJBQFxmXmLN3G394XZPJJ2x8eYowX7bCguYf4foGd9f+fX6BZn/2shgcEVzI29Lgmn a/CIb86IMYoHVCph7m3Dq24VOLK6QVGvSxtBLLd7eLMWzUPxmQozzlz8Wsm3ldcWU3/1azZaxfRdN ivjtSs0elDHLjXWNShGSNCplbNCELPDTrNqEq8cYJvrtCjlqiG+Dkovm1cbMILzKa8YgdmJHljLXN DzKUWyn5Dx76IMx/A51A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozEeE-00077H-63 for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 05:12:30 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249197 Archived-At: To reproduce, visit any C source file in the Emacs tree, turn on c-ts-mode or c++-ts-mode, go to the middle of some function, and type M-: (treesit-beginning-of-defun) RET or M-: (treesit-end-of-defun) RET This will move point to very strange places, which generally are neither the beginning nor the end of the function. In very simple functions, like this one: void __executable_start (void) { emacs_abort (); } the result is correct. But once the function is even slightly more complicated, for example, like this: static int margin_glyphs_to_reserve (struct window *w, int total_glyphs, int margin) { if (margin > 0) { int width = w->total_cols; double d = max (0, margin); d = min (width / 2 - 1, d); /* Since MARGIN is positive, we cannot possibly have less than one glyph for the marginal area. */ return max (1, (int) ((double) total_glyphs / width * d)); } return 0; } the results are very far off the mark. These two functions are the only ones to move by defuns in treesit-based modes, right? So they should be improved, IMO. In GNU Emacs 29.0.50 (build 2273, i686-pc-mingw32) of 2022-11-27 built on HOME-C4E4A596F7 Repository revision: 80dcd78ff1fce3241043edf1951289eef0bf50c9 Repository branch: master Windowing system distributor 'Microsoft Corp.', version 5.1.2600 System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) Configured using: 'configure -C --prefix=/d/usr --with-wide-int --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: C Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils misearch multi-isearch vc-git diff-mode easy-mmode vc-dispatcher c-ts-mode rx treesit cl-seq cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 60472 7440) (symbols 48 7296 0) (strings 16 20076 2163) (string-bytes 1 498360) (vectors 16 11107) (vector-slots 8 164960 11733) (floats 8 29 319) (intervals 40 2962 92) (buffers 896 14))