From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60176: 29.0.60; Fallback file variable mode if treesitter is not usable Date: Mon, 19 Dec 2022 19:47:03 +0200 Message-ID: <83v8m7cmlk.fsf@gnu.org> References: <61db3ccacc2697d0b740315af495fca2@sadiqpk.org> <86359bhmfx.fsf@mail.linkov.net> <83o7rzeflc.fsf@gnu.org> <86o7rzfivi.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15417"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sadiq@sadiqpk.org, monnier@iro.umontreal.ca, 60176@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 19 18:47:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7KER-0003qR-SZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Dec 2022 18:47:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7KEC-0003qk-KR; Mon, 19 Dec 2022 12:47:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KEB-0003qJ-3G for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 12:47:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7KEA-00004y-RR for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 12:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7KEA-0005O1-Cl for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 12:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Dec 2022 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60176 X-GNU-PR-Package: emacs Original-Received: via spool by 60176-submit@debbugs.gnu.org id=B60176.167147202020699 (code B ref 60176); Mon, 19 Dec 2022 17:47:02 +0000 Original-Received: (at 60176) by debbugs.gnu.org; 19 Dec 2022 17:47:00 +0000 Original-Received: from localhost ([127.0.0.1]:39432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7KE8-0005Nn-Ew for submit@debbugs.gnu.org; Mon, 19 Dec 2022 12:47:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7KE6-0005Ng-NW for 60176@debbugs.gnu.org; Mon, 19 Dec 2022 12:46:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KE0-0008VG-BH; Mon, 19 Dec 2022 12:46:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DDLW2IeANt/MnIBGFh4FFzqEuM/o7AUJlcR2SjlLA5g=; b=JUUKMsXsyc3/ 0f/U30anJEQWESMyiyzYFhrFIBDmQQp6HjK6/JcfV28OhNn9GCpF81BJb8odKYhipFdqzkvCH3ajU HNlhMsS4Pb4TWtFFSNexGdxjqh2UCwbjcRcJU/XM8pe3M1R8S4DOkAznCuq6//QXBKjydXFsyee0X QfVktV2tFSqUDhJvVIvJ0kDdWtyWa90Yc371f1qFNPQGckTBE9VID6WNsmlANZY7psf8UcPNH82QG eDUfPYCh5I7NdtJabuwrCW0Xbmq0nUjflzCFXO/lgVDB0PUPTo2pPfxhD1m/OYbzGsVj/lJCBpnZ8 61u7SL9OhPiB+gxqwoT1ag==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KDz-0001j9-OS; Mon, 19 Dec 2022 12:46:52 -0500 In-Reply-To: <86o7rzfivi.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 19 Dec 2022 19:29:13 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251447 Archived-At: > From: Juri Linkov > Cc: sadiq@sadiqpk.org, monnier@iro.umontreal.ca, 60176@debbugs.gnu.org > Date: Mon, 19 Dec 2022 19:29:13 +0200 > > >> So to completely cover all needs, 'major-mode-remap-alist' should > >> support a predicate as well. For example, > >> > >> (setq major-mode-remap-alist '((c-mode #'treesit-available-p c-ts-mode))) > > > > I think the idea is that this should happen by default, not as a > > (not-so-trivial) customization by the users. > > Then 'c-ts-mode' should fall back to 'c-mode' when treesit is not available? > Like this: > > ``` > diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el > index cf941236f82..5004b9a5e1d 100644 > --- a/lisp/progmodes/c-ts-mode.el > +++ b/lisp/progmodes/c-ts-mode.el > @@ -616,7 +616,7 @@ c-ts-mode > (define-derived-mode c-ts-mode c-ts-base-mode "C" > > (unless (treesit-ready-p 'c) > - (error "Tree-sitter for C isn't available")) > + (c-mode)) Yes. But not literally like that, because, for example, we don't want that to happen when c-ts-mode is invoked interactively by the user -- in that case we do want to signal an error. The automatic fallback should IMO happen only in situations like mode specifications in 'mode' cookies or file-local variables, where it is better to visit in a similar mode than completely fail visiting a file.