From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Mon, 30 Jan 2023 21:02:05 +0200 Message-ID: <83v8kn3kya.fsf@gnu.org> References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <20221125175209.51166C004B6@vcs2.savannah.gnu.org> <6c9d91cffc1bfd801530@heytings.org> <6c9d91cffc394613f58a@heytings.org> <83eds0ksev.fsf@gnu.org> <8aadf0ddd54c85c8144a@heytings.org> <831qnhg3d9.fsf@gnu.org> <9757fbea37611e9c44b9@heytings.org> <83cz6yacxt.fsf@gnu.org> <6943e04e30e5a02a52e6@heytings.org> <838rhk5fy1.fsf@gnu.org> <6943e04e30a40824e107@heytings.org> <83k0143q37.fsf@gnu.org> <012b781c-d4dd-0ec5-4c15-a997879690e9@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22059"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 20:03:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMZQw-0005Xj-D3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 20:03:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMZQr-0006Jn-Lr; Mon, 30 Jan 2023 14:03:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMZQl-0006J3-59 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 14:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMZQk-0001zs-TE for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 14:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMZQk-0003ft-Eh for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 14:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 19:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.167510534214071 (code B ref 56682); Mon, 30 Jan 2023 19:03:02 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 30 Jan 2023 19:02:22 +0000 Original-Received: from localhost ([127.0.0.1]:50596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMZQ6-0003et-Bz for submit@debbugs.gnu.org; Mon, 30 Jan 2023 14:02:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMZQ4-0003eg-PD for 56682@debbugs.gnu.org; Mon, 30 Jan 2023 14:02:21 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMZPz-0001pd-7S; Mon, 30 Jan 2023 14:02:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=pzkxE7b+5rnv6bhmM+lD5mSt5Z5U7+VNy9RfWtxwLJM=; b=Qc2NtaIsFgflbxrGpsPw BBWgqeJYh80XpVtUyd3duZo5bIj8Qz6QVgMkYFhG+XubYgJ44At097lyTFweOpS+ZE47qFDxWizPT U+PR4Yd3eoh1Tipv4oUoK5xGpsFdRt7Zs5uoPmLAUDtnf+gE2N8WOTSF9vFuaz+OH1ns6xgABiUyu prz4EkUG14T4PnhDoycYUhaSZv/FsmqTGYAxIx5QRkOcmWPPxD4BZ8u1UPJ9B1glWwuQc4a0hEf/t o0Hnv9kbD7ap3wiF7Vh63x4hiUVY1fatMpI+enZ4MBFEZSZ/zs4Un7I/z/DXxJ8zEOjbzaut+uamB 5czP/AEjaftIbg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMZPw-0001Bg-4E; Mon, 30 Jan 2023 14:02:15 -0500 In-Reply-To: <012b781c-d4dd-0ec5-4c15-a997879690e9@yandex.ru> (message from Dmitry Gutov on Mon, 30 Jan 2023 20:56:15 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254473 Archived-At: > Date: Mon, 30 Jan 2023 20:56:15 +0200 > Cc: 56682@debbugs.gnu.org, monnier@iro.umontreal.ca > From: Dmitry Gutov > > On 30/01/2023 19:11, Eli Zaretskii wrote: > >> Date: Mon, 30 Jan 2023 15:03:54 +0000 > >> From: Gregory Heytings > >> cc:56682@debbugs.gnu.org,monnier@iro.umontreal.ca > >> > >>> What exactly will that remove? only what's on the feature branch, or > >>> also some stuff on the emacs-29 branch? > >> The "locked narrowing" feature, IOW, the portions of editfns.c in which it > >> is implemented, and its use around pre-command-hook, post-command-hook and > >> fontification-functions. > >> > >>> And what are your reasons for removing this? It is hard to tell whether > >>> or not I agree without knowing to what I should agree 😉 > >>> > >> The reason is that I'm now convinced that it is not a good solution to the > >> problem of ill-behaving modes in the presence of long lines. > > So we are removing all the stuff that prevented font-lock from slowing > > down redisplay when long lines are in the buffer? IOW, something > > which we have for several months, and which so far brought up only one > > complaint? > > More than one, FTR. > > I'm not 100% sure what Gregory's plan is, but note that a significant > part of the redisplay slowdowns wasn't caused by font-lock, and thus the > removal of locking will not regress those performance improvements. > > And for those (potential?) cases where font-lock is a real problem for > performance, we could stop it from widening using an existing knob. Yes, this is an old and known disagreement between us. But this is my decision to make, not anyone else's.