From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62265: Underline does not work in Terminal Emacs Date: Sun, 19 Mar 2023 13:37:14 +0200 Message-ID: <83v8ix9dlh.fsf@gnu.org> References: <87wn3ex8ik.fsf@kisara.moe> <83edpmaqrs.fsf@gnu.org> <7cf462de-97f7-26ef-a33f-e3ff59c8b55e@gmail.com> <87mt49jbql.fsf@kisara.moe> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12239"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 62265@debbugs.gnu.org To: Mohsin Kaleem Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 19 12:38:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdrMd-0002uk-Fk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Mar 2023 12:38:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdrMT-0001h8-F0; Sun, 19 Mar 2023 07:38:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdrMQ-0001gk-Uy for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 07:38:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdrMQ-0001sx-48 for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 07:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdrMP-0000BS-Rj for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 07:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Mar 2023 11:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62265 X-GNU-PR-Package: emacs Original-Received: via spool by 62265-submit@debbugs.gnu.org id=B62265.1679225837649 (code B ref 62265); Sun, 19 Mar 2023 11:38:01 +0000 Original-Received: (at 62265) by debbugs.gnu.org; 19 Mar 2023 11:37:17 +0000 Original-Received: from localhost ([127.0.0.1]:49568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdrLh-0000AP-Ba for submit@debbugs.gnu.org; Sun, 19 Mar 2023 07:37:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdrLf-0000A9-Rm for 62265@debbugs.gnu.org; Sun, 19 Mar 2023 07:37:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdrLa-0001lW-2s; Sun, 19 Mar 2023 07:37:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sZsTESbTBkJPbPGUwBLU4yr2kSoLxRa2wxFsPwpSjHk=; b=OwqCl3Cj1Te7 EkKG9fL6zFBmhupUmQnpQ69qtrfPDbAtgH0Lbmx6BEJ4hrWtnJCzWiLpHG7dPrs8fSwNT8m3FO271 yydxycgfjvJSUS64sJ3DqSlLYgsO9toa4o3EkwhbupO6FvP8h79FDxMYuaGZymeSV5cG7blszMZP2 IU2Ot6gU0aLY/tVNZdg5M58NS4irO2psHCQJj26pHs5OJOBlEGy3HUVUUqPK2CQtmaxigTUn+xgHr 3yMlFL+a9QocYI2zSgdUhWxFX44BAhHWybwVbEfFBaJeXCChk+/r0OGybmh1W6N1D7Qjzb3t/7K/x gw6OOPu3yNeA899UR1bfMA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdrLZ-0006Dh-Ga; Sun, 19 Mar 2023 07:37:09 -0400 In-Reply-To: <87mt49jbql.fsf@kisara.moe> (message from Mohsin Kaleem on Sun, 19 Mar 2023 10:07:14 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258227 Archived-At: > From: Mohsin Kaleem > Cc: 62265@debbugs.gnu.org > Date: Sun, 19 Mar 2023 10:07:14 +0000 > > Hi, so turns out terminfo returns a max-ptr for tigetstr when the > terminfo definition is missing. There's checks for this for setb24 and > setf24 but not in the patch I supplied. Updated to check this and added > a macro definition to avoid repeating the same condition logic 3 times. Thanks. However, what about the non-TERMINFO branch? Do termcap databases support this capability and tigetstr? I wonder whether we should do one of the following: . support "smxx" only when TERMINFO is defined . support "smxx" regardless of whether TERMINFO is defined With your patch, it's neither here nor there. tgetstr is documented to pay attention only to the first 2 characters of the capability's name, at least in the ncurses documentation. If this is generally so in other curses libraries, then leaving the tgetstr call intact in the non-TERMINFO case makes no sense.