From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Fri, 05 May 2023 21:45:01 +0300 Message-ID: <83v8h6hb2q.fsf@gnu.org> References: <87zgb6uk2r.fsf@hyperspace> <87r0spa712.fsf@posteo.net> <87edopiif5.fsf@hyperspace> <87wn2bzvcp.fsf@hyperspace> <835y9vbyfr.fsf@gnu.org> <87mt36uwl8.fsf@hyperspace> <83ttxd8k1z.fsf@gnu.org> <87v8hrn56l.fsf@hyperspace> <87cz3w2lvb.fsf@posteo.net> <87jzy3ku6u.fsf@hyperspace> <87bkje93ou.fsf@posteo.net> <87y1mhihhy.fsf@hyperspace> <87ildbet2d.fsf@hyperspace> <831qjyoqj5.fsf@gnu.org> <87h6suolt2.fsf@hyperspace> <83ttwun4q4.fsf@gnu.org> <87o7n0fr9e.fsf@hyperspace> <878re3cqro.fsf@posteo.net> <83ild7jq5c.fsf@gnu.org> <87v8h7ba55.fsf@posteo.net> <83zg6ji806.fsf@gnu.org> <87wn1mlmwx.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34494"; mail-complaints-to="usenet@ciao.gmane.io" Cc: soliditsallgood@mailbox.org, felician.nemeth@gmail.com, 60418@debbugs.gnu.org, stefankangas@gmail.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 05 20:45:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pv0Ql-0008lA-Vq for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 May 2023 20:45:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pv0QS-0001sD-T5; Fri, 05 May 2023 14:45:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv0QQ-0001rs-Vn for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 14:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pv0QQ-0000JA-MI for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 14:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pv0QQ-0003aV-6y for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 14:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 May 2023 18:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.168331225913716 (code B ref 60418); Fri, 05 May 2023 18:45:02 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 5 May 2023 18:44:19 +0000 Original-Received: from localhost ([127.0.0.1]:57546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv0Pj-0003ZA-Bl for submit@debbugs.gnu.org; Fri, 05 May 2023 14:44:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv0Pf-0003Yv-OU for 60418@debbugs.gnu.org; Fri, 05 May 2023 14:44:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv0PY-00009V-PO; Fri, 05 May 2023 14:44:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=1OTSiNVWhddbEXWyHQ3aJBn7TYLNNOne0d/J/IvG2ls=; b=LSu2j0ouLd4R3NDnTker t03BiSzGpN78kF1KTFDF7Fh/3leP9j2uL40xgxqFWGt75ZhmcK7gjx9rhXruWFoMTx+9n5I4rKrFA 0462XptZRvV5w+qurPxyC+RjBCgqz7shHGVMzZ+kRUWtEkqB7O8ya68onayJ3q2XaoJOUF2GHWb0q afu4IZzhkBETiNleh3NF/qgoHDpJfpInQPMT6I4Cn2raLTZWfZdVmhoISGmXX8sXSa3QFmX2I7z8c b/2G35Nllsc6rFFhxJxABe+Agoh4o4+meKiUQMcA+2ZQ0eSBxpbFjeLcgdmHV3Mm/u7DzdA2W53iU ntsubbxvvy9Okg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv0PY-0005d2-9V; Fri, 05 May 2023 14:44:08 -0400 In-Reply-To: <87wn1mlmwx.fsf@posteo.net> (message from Philip Kaludercic on Fri, 05 May 2023 17:15:42 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261138 Archived-At: > From: Philip Kaludercic > Cc: soliditsallgood@mailbox.org, 60418@debbugs.gnu.org, > felician.nemeth@gmail.com, stefankangas@gmail.com > Date: Fri, 05 May 2023 17:15:42 +0000 > > Eli Zaretskii writes: > > >> No, the commit of the latest release is interpreted the same way as > >> elpa-admin.el does, namely the last revision that modified the "Version" > >> header. If no such commit can be found, then a message is printed out > >> and the installation continues under the assumption that the package is > >> using a rolling-release model. > > > > I thought package-vc-install is used (or at least can be used) to > > fetch the latest HEAD from the upstream repository? I even thought > > this was its main raison d'être? > > > > If that's not true, does it mean we have no means for package users to > > track the latest development code of a package? > > This is true, for package-vc-install, but the idea was not do this for > the :vc keyword to use-package. But I wrote the above as a comment to a patch to package-vc.el, not to use-package. So why use-package is relevant here? > My understanding is that the main > interest here is to install packages that are not available via package > archives. And as use-package is a popular means of bootstrapping a > configuration, it seems the right approach to use the commit of the > latest revision, instead of just any commit to avoid instability. My understanding is that the :rev keyword allows to use any value that is acceptable to package-vc-install. I understand that in most cases users will want to install the latest, but once we decided to support :rev, we must allow any valid value there. Right? > By default, this function installs the last revision of the > package available from its repository. If REV is a string, it > describes the revision to install, as interpreted by the VC > backend. The special value `:last-release' (interactively, the > prefix argument), will use the commit of the latest release, if > it exists. The latest revision is determined by the latest ^^^^^^^^^^^^^^^ "last release", not "latest revision": you are explaining what the previous sentence said. > revision to modify the \"Version\" header of the main file. > > But I couldn't come up with an elegant way to avoid the passive voice in > the last sentence. Here's one way: The last release is the latest revision which changed the \"Version:\" header of the package's main Lisp file.