From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64391: buffer narrowing slowdown regression in emacs 29 Date: Fri, 07 Jul 2023 13:23:11 +0300 Message-ID: <83v8ewf2b4.fsf@gnu.org> References: <87r0psb51z.fsf@ust.hk> <0AD15A09-F669-48C0-AF5C-971D52F5BF8E@gmail.com> <83v8f3q1ff.fsf@gnu.org> <50A46AAC-2089-45CB-A355-CCB2B4EA8D76@gmail.com> <5995c9ed6a0b39c3070c@heytings.org> <83a5wak1tr.fsf@gnu.org> <26cee506f708f3c6cfe1@heytings.org> <26cee506f70bbc9de58b@heytings.org> <83h6qghpdc.fsf@gnu.org> <26cee506f77e9c87e325@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36411"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 07 12:24:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHidN-0009EA-9q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jul 2023 12:24:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHidA-0004FX-5l; Fri, 07 Jul 2023 06:24:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHid8-0004FE-A8 for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 06:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHid8-000401-2A for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 06:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHid7-0005I9-Sw; Fri, 07 Jul 2023 06:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 07 Jul 2023 10:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64391 X-GNU-PR-Package: emacs,gnus X-Debbugs-Original-Cc: acohen@ust.hk, 64391@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca, bugs@gnus.org Original-Received: via spool by 64391-submit@debbugs.gnu.org id=B64391.168872539820280 (code B ref 64391); Fri, 07 Jul 2023 10:24:01 +0000 Original-Received: (at 64391) by debbugs.gnu.org; 7 Jul 2023 10:23:18 +0000 Original-Received: from localhost ([127.0.0.1]:42601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHicP-0005H2-Nd for submit@debbugs.gnu.org; Fri, 07 Jul 2023 06:23:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHicO-0005Gp-69 for 64391@debbugs.gnu.org; Fri, 07 Jul 2023 06:23:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHicH-0002qu-LY; Fri, 07 Jul 2023 06:23:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n45pKPpum6Ww+K4OfBZfI4IWmXag+iTf5Bvk0vtNg7w=; b=DN59+rKuWe/o gX11vk7I64ODhX8JXbL0TQe1EwKJA5xxdL61qzBMlk0ny3inVu6JeqdVUuT7U/9O51zbYXS3dO65O x9NDrhHAY/aB8TQObMy2e0UePJjhvX0m2vMsj+y2x14jyUZLH1Ln8fwqVWk++SEdwmokGbukd1Y8u NKn5U0/VWHreqHRj7G+cCpcbSeBiNngdUhhY25hGj5z4uh1F6374/gnsWeMo+F4d0zI9TBnfYHE7X rFM1xubLlxBUfRTNq3ZvIyzkIm0iLr1yZgVahvgpyKH8RTd+HdumMN0RCT5h6PO9INyFdEyc0g8Je XF4XbmytstFM4aMZ3ypQmw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHicH-0002J1-59; Fri, 07 Jul 2023 06:23:09 -0400 In-Reply-To: (message from Gregory Heytings on Fri, 07 Jul 2023 10:00:48 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264712 Archived-At: > Date: Fri, 07 Jul 2023 10:00:48 +0000 > From: Gregory Heytings > cc: acohen@ust.hk, 64391@debbugs.gnu.org, Eli Zaretskii , > monnier@iro.umontreal.ca, bugs@gnus.org > > > I have one question about the new `with-restriction` macro: if it is > > intended as a convenience macro for unlabelled narrowing as well, > > shouldn't it then expand to the obvious > > > > (save-restriction > > (narrow-to-region BEG END) > > BODY) > > > > instead the much more expensive call to a helper function? > > Yes. In fact now that we have a separate function for the labeled case, > we can remove the funcall in both cases. Patch attached. You are killing me.